From: Markus Elfring <Markus.Elfring@web.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Himanshu Jha <himanshujha199640@gmail.com>,
kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
YueHaibing <yuehaibing@huawei.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Sat, 19 Oct 2019 16:06:52 +0200 [thread overview]
Message-ID: <389d4ad6-7f57-2060-f00a-ac2295052b22@web.de> (raw)
In-Reply-To: <20191019120941.GL3125@piout.net>
> What are the additional effects?
I suggest to take another look at the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
("drivers: provide devm_platform_ioremap_resource()" from 2019-02-20)
which triggered the discussed software evolution.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/base/platform.c
> What is the end goal of converting all the existing drivers to devm_platform_ioremap_resource?
It was accepted by well-known Linux developers to put two function calls
into another wrapper function.
> This is not an evolution, it is unnecessary churn. Those patches have no
> benefit and eat up very valuable reviewer time.
I am curious if other contributors would like to describe more variants
of software development opinions in affected areas.
>> How will such feedback influence the development and integration of
>> further scripts for the semantic patch language (Coccinelle software)?
>
> There are a few other scripts that have no added value when applied to
> existing code, like ptr_ret.cocci.
Would you like to clarify concerns around such source code transformation
approaches in more detail?
Regards,
Markus
next prev parent reply other threads:[~2019-10-19 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:22 [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Alexandre Belloni
2019-10-17 14:34 ` Julia Lawall
2019-10-17 16:13 ` Marc Zyngier
2019-10-19 11:35 ` Markus Elfring
2019-10-19 20:43 ` Marc Zyngier
2019-10-19 22:13 ` Joe Perches
2019-10-24 15:40 ` Masahiro Yamada
2019-10-24 18:30 ` Markus Elfring
2019-10-25 8:08 ` Andy Shevchenko
2019-10-25 8:38 ` Julia Lawall
2019-10-29 2:58 ` Masahiro Yamada
2019-10-29 8:55 ` Julia Lawall
2019-10-20 5:38 ` Julia Lawall
2019-10-20 9:34 ` Marc Zyngier
2019-10-20 5:45 ` Markus Elfring
2019-10-19 9:00 ` [PATCH] " Markus Elfring
2019-10-19 12:09 ` Alexandre Belloni
2019-10-19 14:06 ` Markus Elfring [this message]
2019-10-19 14:29 ` Bartosz Golaszewski
2019-10-19 16:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=389d4ad6-7f57-2060-f00a-ac2295052b22@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
--cc=yamada.masahiro@socionext.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).