From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Joe Perches <joe@perches.com>
Cc: Marc Zyngier <maz@kernel.org>,
Markus Elfring <Markus.Elfring@web.de>,
Himanshu Jha <himanshujha199640@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Thomas Gleixner <tglx@linutronix.de>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Fri, 25 Oct 2019 00:40:52 +0900 [thread overview]
Message-ID: <CAK7LNAQqSThGRM_wRGR2ou3B+Oqpr0nF9Fg4rhSR4Hvnxwnj3g@mail.gmail.com> (raw)
In-Reply-To: <c8816d85b696cb96318e17b7010b84f09bc67bf7.camel@perches.com>
On Sun, Oct 20, 2019 at 7:13 AM Joe Perches <joe@perches.com> wrote:
>
> On Sat, 2019-10-19 at 21:43 +0100, Marc Zyngier wrote:
> > Providing Coccinelle scripts that scream about perfectly valid code is
> > pointless, and the result is actively harmful.
>
> Doubtful.
>
> If the new code is smaller object code and correct
> than the conversion is worthwhile.
I agree.
We use multi-platform defconfig.
I always appreciate the code refactoring
that reduces the object size.
> fyi:
>
> There are already ~450 uses of this function and maybe
> ~800 possible additional conversions.
>
> > If said script was providing a correct semantic patch instead of being
> > an incentive for people to churn untested patches that span the whole
> > tree, that'd be a different story.
>
> Right.
>
>
Alexandre Belloni used
https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@www.loen.fr/
as a reference, but this is not the output from coccicheck.
The patch author just created a wrong patch by hand.
The deleted semantic patch supports MODE=patch,
which creates a correct patch, and is useful.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2019-10-24 15:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:22 [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Alexandre Belloni
2019-10-17 14:34 ` Julia Lawall
2019-10-17 16:13 ` Marc Zyngier
2019-10-19 11:35 ` Markus Elfring
2019-10-19 20:43 ` Marc Zyngier
2019-10-19 22:13 ` Joe Perches
2019-10-24 15:40 ` Masahiro Yamada [this message]
2019-10-24 18:30 ` Markus Elfring
2019-10-25 8:08 ` Andy Shevchenko
2019-10-25 8:38 ` Julia Lawall
2019-10-29 2:58 ` Masahiro Yamada
2019-10-29 8:55 ` Julia Lawall
2019-10-20 5:38 ` Julia Lawall
2019-10-20 9:34 ` Marc Zyngier
2019-10-20 5:45 ` Markus Elfring
2019-10-19 9:00 ` [PATCH] " Markus Elfring
2019-10-19 12:09 ` Alexandre Belloni
2019-10-19 14:06 ` Markus Elfring
2019-10-19 14:29 ` [PATCH] " Bartosz Golaszewski
2019-10-19 16:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQqSThGRM_wRGR2ou3B+Oqpr0nF9Fg4rhSR4Hvnxwnj3g@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).