From: Dan Murphy <dmurphy@ti.com>
To: "Andrew F. Davis" <afd@ti.com>, <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, robh@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml
Date: Mon, 11 May 2020 10:23:50 -0500 [thread overview]
Message-ID: <38fffe57-bcc2-b87f-6589-09bb97b5c67a@ti.com> (raw)
In-Reply-To: <a5eae705-672b-acef-8850-0811a6ea13fb@ti.com>
Andrew
On 5/11/20 10:22 AM, Andrew F. Davis wrote:
> On 5/7/20 2:30 PM, Dan Murphy wrote:
>> Convert the bq27xxx.txt to yaml format
>>
>> CC: Pali Rohár <pali@kernel.org>
>> CC: Andrew F. Davis <afd@ti.com>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>> .../bindings/power/supply/bq27xxx.txt | 56 ------------
>> .../bindings/power/supply/bq27xxx.yaml | 86 +++++++++++++++++++
>> 2 files changed, 86 insertions(+), 56 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.txt
>> create mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt b/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
>> deleted file mode 100644
>> index 4fa8e08df2b6..000000000000
>> --- a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
>> +++ /dev/null
>> @@ -1,56 +0,0 @@
>> -TI BQ27XXX fuel gauge family
>> -
>> -Required properties:
>> -- compatible: contains one of the following:
>> - * "ti,bq27200" - BQ27200
>> - * "ti,bq27210" - BQ27210
>> - * "ti,bq27500" - deprecated, use revision specific property below
>> - * "ti,bq27510" - deprecated, use revision specific property below
>> - * "ti,bq27520" - deprecated, use revision specific property below
>> - * "ti,bq27500-1" - BQ27500/1
>
> This doesn't look right, these are two parts, we should be specific in
> DT, so:
>
> ti,bq27500
> ti,bq27501
>
> should be separate like that.
I agree if they are 2 different parts but the code has
{ .compatible = "ti,bq27500-1" },
But it has no consumers.
So the ti,bq27500-1 compatible should be deprecated and ti,bq27501
should be added and the ti,bq27500 should be reinstated.
Dan
prev parent reply other threads:[~2020-05-11 15:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:30 [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml Dan Murphy
2020-05-10 16:17 ` Sebastian Reichel
2020-05-11 12:25 ` Dan Murphy
2020-05-11 14:32 ` Sebastian Reichel
2020-05-11 14:29 ` Dan Murphy
2020-05-11 14:57 ` Sebastian Reichel
2020-05-11 14:55 ` Dan Murphy
2020-05-11 15:30 ` Sebastian Reichel
2020-05-11 19:06 ` Dan Murphy
2020-05-11 15:22 ` Andrew F. Davis
2020-05-11 15:23 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38fffe57-bcc2-b87f-6589-09bb97b5c67a@ti.com \
--to=dmurphy@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).