From: "Andrew F. Davis" <afd@ti.com>
To: Dan Murphy <dmurphy@ti.com>, <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, robh@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml
Date: Mon, 11 May 2020 11:22:30 -0400 [thread overview]
Message-ID: <a5eae705-672b-acef-8850-0811a6ea13fb@ti.com> (raw)
In-Reply-To: <20200507183013.27261-1-dmurphy@ti.com>
On 5/7/20 2:30 PM, Dan Murphy wrote:
> Convert the bq27xxx.txt to yaml format
>
> CC: Pali Rohár <pali@kernel.org>
> CC: Andrew F. Davis <afd@ti.com>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> .../bindings/power/supply/bq27xxx.txt | 56 ------------
> .../bindings/power/supply/bq27xxx.yaml | 86 +++++++++++++++++++
> 2 files changed, 86 insertions(+), 56 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> create mode 100644 Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt b/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> deleted file mode 100644
> index 4fa8e08df2b6..000000000000
> --- a/Documentation/devicetree/bindings/power/supply/bq27xxx.txt
> +++ /dev/null
> @@ -1,56 +0,0 @@
> -TI BQ27XXX fuel gauge family
> -
> -Required properties:
> -- compatible: contains one of the following:
> - * "ti,bq27200" - BQ27200
> - * "ti,bq27210" - BQ27210
> - * "ti,bq27500" - deprecated, use revision specific property below
> - * "ti,bq27510" - deprecated, use revision specific property below
> - * "ti,bq27520" - deprecated, use revision specific property below
> - * "ti,bq27500-1" - BQ27500/1
This doesn't look right, these are two parts, we should be specific in
DT, so:
ti,bq27500
ti,bq27501
should be separate like that.
Andrew
> - * "ti,bq27510g1" - BQ27510-g1
> - * "ti,bq27510g2" - BQ27510-g2
> - * "ti,bq27510g3" - BQ27510-g3
> - * "ti,bq27520g1" - BQ27520-g1
> - * "ti,bq27520g2" - BQ27520-g2
> - * "ti,bq27520g3" - BQ27520-g3
> - * "ti,bq27520g4" - BQ27520-g4
> - * "ti,bq27521" - BQ27521
> - * "ti,bq27530" - BQ27530
> - * "ti,bq27531" - BQ27531
> - * "ti,bq27541" - BQ27541
> - * "ti,bq27542" - BQ27542
> - * "ti,bq27546" - BQ27546
> - * "ti,bq27742" - BQ27742
> - * "ti,bq27545" - BQ27545
> - * "ti,bq27411" - BQ27411
> - * "ti,bq27421" - BQ27421
> - * "ti,bq27425" - BQ27425
> - * "ti,bq27426" - BQ27426
> - * "ti,bq27441" - BQ27441
> - * "ti,bq27621" - BQ27621
> -- reg: integer, I2C address of the fuel gauge.
> -
> -Optional properties:
> -- monitored-battery: phandle of battery characteristics node
> - The fuel gauge uses the following battery properties:
> - + energy-full-design-microwatt-hours
> - + charge-full-design-microamp-hours
> - + voltage-min-design-microvolt
> - Both or neither of the *-full-design-*-hours properties must be set.
> - See Documentation/devicetree/bindings/power/supply/battery.txt
> -
> -Example:
> -
> - bat: battery {
> - compatible = "simple-battery";
> - voltage-min-design-microvolt = <3200000>;
> - energy-full-design-microwatt-hours = <5290000>;
> - charge-full-design-microamp-hours = <1430000>;
> - };
> -
> - bq27510g3: fuel-gauge@55 {
> - compatible = "ti,bq27510g3";
> - reg = <0x55>;
> - monitored-battery = <&bat>;
> - };
> diff --git a/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
> new file mode 100644
> index 000000000000..54f497c291f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq27xxx.yaml
> @@ -0,0 +1,86 @@
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (C) 2020 Texas Instruments Incorporated
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/bq27xxx.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: TI BQ27XXX fuel gauge family
> +
> +maintainers:
> + - Pali Rohár <pali@kernel.org>
> + - Andrew F. Davis <afd@ti.com>
> + - Sebastian Reichel <sre@kernel.org>
> +
> +description: |
> + Support various Texas Instruments fuel gauge devices that share similar
> + register maps and power supply properties
> +
> +properties:
> + compatible:
> + enum:
> + - ti,bq27200 - BQ27200
> + - ti,bq27210 - BQ27210
> + - ti,bq27500 - deprecated, use revision specific property below
> + - ti,bq27510 - deprecated, use revision specific property below
> + - ti,bq27520 - deprecated, use revision specific property below
> + - ti,bq27500-1 - BQ27500/1
> + - ti,bq27510g1 - BQ27510-g1
> + - ti,bq27510g2 - BQ27510-g2
> + - ti,bq27510g3 - BQ27510-g3
> + - ti,bq27520g1 - BQ27520-g1
> + - ti,bq27520g2 - BQ27520-g2
> + - ti,bq27520g3 - BQ27520-g3
> + - ti,bq27520g4 - BQ27520-g4
> + - ti,bq27521 - BQ27521
> + - ti,bq27530 - BQ27530
> + - ti,bq27531 - BQ27531
> + - ti,bq27541 - BQ27541
> + - ti,bq27542 - BQ27542
> + - ti,bq27546 - BQ27546
> + - ti,bq27742 - BQ27742
> + - ti,bq27545 - BQ27545
> + - ti,bq27411 - BQ27411
> + - ti,bq27421 - BQ27421
> + - ti,bq27425 - BQ27425
> + - ti,bq27426 - BQ27426
> + - ti,bq27441 - BQ27441
> + - ti,bq27621 - BQ27621
> +
> + reg:
> + maxItems: 1
> + description: integer, I2C address of the fuel gauge.
> +
> + monitored-battery:
> + description: |
> + phandle of battery characteristics node.
> + The fuel gauge uses the following battery properties:
> + - energy-full-design-microwatt-hours
> + - charge-full-design-microamp-hours
> + - voltage-min-design-microvolt
> + Both or neither of the *-full-design-*-hours properties must be set.
> + See Documentation/devicetree/bindings/power/supply/battery.txt
> +
> +required:
> + - compatible
> + - reg
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + bat: battery {
> + compatible = "simple-battery";
> + voltage-min-design-microvolt = <3200000>;
> + energy-full-design-microwatt-hours = <5290000>;
> + charge-full-design-microamp-hours = <1430000>;
> + };
> +
> + bq27510g3: fuel-gauge@55 {
> + compatible = "ti,bq27510g3";
> + reg = <0x55>;
> + monitored-battery = <&bat>;
> + };
> + };
>
next prev parent reply other threads:[~2020-05-11 15:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 18:30 [PATCH v2] dt-bindings: power: Convert bq27xxx dt to yaml Dan Murphy
2020-05-10 16:17 ` Sebastian Reichel
2020-05-11 12:25 ` Dan Murphy
2020-05-11 14:32 ` Sebastian Reichel
2020-05-11 14:29 ` Dan Murphy
2020-05-11 14:57 ` Sebastian Reichel
2020-05-11 14:55 ` Dan Murphy
2020-05-11 15:30 ` Sebastian Reichel
2020-05-11 19:06 ` Dan Murphy
2020-05-11 15:22 ` Andrew F. Davis [this message]
2020-05-11 15:23 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5eae705-672b-acef-8850-0811a6ea13fb@ti.com \
--to=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).