* [PATCH] [IA64] disable interrupts when exiting from ia64_mca_cmc_int_handler()
@ 2012-02-08 14:32 Jiri Kosina
2012-02-09 0:24 ` Luck, Tony
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Kosina @ 2012-02-08 14:32 UTC (permalink / raw)
To: Tony Luck, Fenghua Yu; +Cc: linux-kernel, Raymund Will, linux-ia64
SAL specification mandates that ia64_mca_log_sal_error_record() gets
called with interrupts enabled, and that's why ia64_mca_cmc_int_handler()
is enabling them. It however forgets to re-disable them when exiting,
which triggers WARN_ON() in generic IRQ handler.
Disable the interrupts again before exiting. This is analogous to
a3967685745 ("[IA64] disable interrupts at end of
ia64_mca_cpe_int_handler()").
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
arch/ia64/kernel/mca.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c
index 84fb405..8192009 100644
--- a/arch/ia64/kernel/mca.c
+++ b/arch/ia64/kernel/mca.c
@@ -1447,6 +1447,8 @@ out:
/* Get the CMC error record and log it */
ia64_mca_log_sal_error_record(SAL_INFO_TYPE_CMC);
+ local_irq_disable();
+
return IRQ_HANDLED;
}
--
Jiri Kosina
SUSE Labs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] [IA64] disable interrupts when exiting from ia64_mca_cmc_int_handler()
2012-02-08 14:32 [PATCH] [IA64] disable interrupts when exiting from ia64_mca_cmc_int_handler() Jiri Kosina
@ 2012-02-09 0:24 ` Luck, Tony
0 siblings, 0 replies; 2+ messages in thread
From: Luck, Tony @ 2012-02-09 0:24 UTC (permalink / raw)
To: Jiri Kosina, Yu, Fenghua; +Cc: linux-kernel, Raymund Will, linux-ia64
> Disable the interrupts again before exiting. This is analogous to
> a3967685745 ("[IA64] disable interrupts at end of
> ia64_mca_cpe_int_handler()").
Thanks. Applied. Should show up in linux-next in a day or two, and
I'll send to Linus in next merge window.
-Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-09 0:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-08 14:32 [PATCH] [IA64] disable interrupts when exiting from ia64_mca_cmc_int_handler() Jiri Kosina
2012-02-09 0:24 ` Luck, Tony
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).