From: Thomas Renninger <trenn@suse.de>
To: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Cc: Laura Abbott <labbott@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq
Date: Mon, 24 Oct 2016 17:11:25 +0200 [thread overview]
Message-ID: <3917157.z59pS4HJyr@skinner> (raw)
In-Reply-To: <331512cb-ccfb-a9eb-fea8-501fa333920c@linux.vnet.ibm.com>
On Thursday, October 20, 2016 01:42:49 PM Shilpasri G Bhat wrote:
> On 10/20/2016 04:23 AM, Laura Abbott wrote:
> > When converting to a shared library in ac5a181d065d ("cpupower: Add
> > cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> > cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> > -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> > Check for the correct return value in cpufreq-set.
> >
> > See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
> >
> > Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> > Reported-by: Julian Seward <jseward@acm.org>
> > Signed-off-by: Laura Abbott <labbott@redhat.com>
> > ---
> > v2: Drop another redundant cpupower_is_cpu_online
>
> Reviewed-by:Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Acked-by: Thomas Renninger <trenn@suse.com>
I wanted to go through all recently sent patches and adjust rebase them to
my lates changes.
But I guess the fact that I push this from day to day because of other
stuff should not hold off such important fixes.
I collect and review all others as well the next day(s)..
Thomas
prev parent reply other threads:[~2016-10-24 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:53 [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq Laura Abbott
2016-10-20 8:12 ` Shilpasri G Bhat
2016-10-24 15:11 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3917157.z59pS4HJyr@skinner \
--to=trenn@suse.de \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=shilpa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).