* [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq
@ 2016-10-19 22:53 Laura Abbott
2016-10-20 8:12 ` Shilpasri G Bhat
0 siblings, 1 reply; 3+ messages in thread
From: Laura Abbott @ 2016-10-19 22:53 UTC (permalink / raw)
To: Thomas Renninger
Cc: Laura Abbott, Shilpasri G Bhat, linux-pm, linux-kernel,
Rafael J. Wysocki
When converting to a shared library in ac5a181d065d ("cpupower: Add
cpuidle parts into library"), cpu_freq_cpu_exists was converted to
cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
-ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
Check for the correct return value in cpufreq-set.
See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Reported-by: Julian Seward <jseward@acm.org>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v2: Drop another redundant cpupower_is_cpu_online
Resend because I've heard nothing about this patch and it's still broken
as far as I can tell.
---
tools/power/cpupower/utils/cpufreq-set.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c
index b4bf769..1eef0ae 100644
--- a/tools/power/cpupower/utils/cpufreq-set.c
+++ b/tools/power/cpupower/utils/cpufreq-set.c
@@ -296,7 +296,7 @@ int cmd_freq_set(int argc, char **argv)
struct cpufreq_affected_cpus *cpus;
if (!bitmask_isbitset(cpus_chosen, cpu) ||
- cpupower_is_cpu_online(cpu))
+ cpupower_is_cpu_online(cpu) != 1)
continue;
cpus = cpufreq_get_related_cpus(cpu);
@@ -316,10 +316,7 @@ int cmd_freq_set(int argc, char **argv)
cpu <= bitmask_last(cpus_chosen); cpu++) {
if (!bitmask_isbitset(cpus_chosen, cpu) ||
- cpupower_is_cpu_online(cpu))
- continue;
-
- if (cpupower_is_cpu_online(cpu) != 1)
+ cpupower_is_cpu_online(cpu) != 1)
continue;
printf(_("Setting cpu: %d\n"), cpu);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq
2016-10-19 22:53 [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq Laura Abbott
@ 2016-10-20 8:12 ` Shilpasri G Bhat
2016-10-24 15:11 ` Thomas Renninger
0 siblings, 1 reply; 3+ messages in thread
From: Shilpasri G Bhat @ 2016-10-20 8:12 UTC (permalink / raw)
To: Laura Abbott, Thomas Renninger; +Cc: linux-pm, linux-kernel, Rafael J. Wysocki
On 10/20/2016 04:23 AM, Laura Abbott wrote:
> When converting to a shared library in ac5a181d065d ("cpupower: Add
> cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> Check for the correct return value in cpufreq-set.
>
> See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
>
> Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> Reported-by: Julian Seward <jseward@acm.org>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> v2: Drop another redundant cpupower_is_cpu_online
Reviewed-by:Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq
2016-10-20 8:12 ` Shilpasri G Bhat
@ 2016-10-24 15:11 ` Thomas Renninger
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Renninger @ 2016-10-24 15:11 UTC (permalink / raw)
To: Shilpasri G Bhat; +Cc: Laura Abbott, Rafael J. Wysocki, linux-kernel, linux-pm
On Thursday, October 20, 2016 01:42:49 PM Shilpasri G Bhat wrote:
> On 10/20/2016 04:23 AM, Laura Abbott wrote:
> > When converting to a shared library in ac5a181d065d ("cpupower: Add
> > cpuidle parts into library"), cpu_freq_cpu_exists was converted to
> > cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and
> > -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success.
> > Check for the correct return value in cpufreq-set.
> >
> > See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
> >
> > Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
> > Reported-by: Julian Seward <jseward@acm.org>
> > Signed-off-by: Laura Abbott <labbott@redhat.com>
> > ---
> > v2: Drop another redundant cpupower_is_cpu_online
>
> Reviewed-by:Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
Acked-by: Thomas Renninger <trenn@suse.com>
I wanted to go through all recently sent patches and adjust rebase them to
my lates changes.
But I guess the fact that I push this from day to day because of other
stuff should not hold off such important fixes.
I collect and review all others as well the next day(s)..
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-19 22:53 [RESEND][PATCHv2] cpupower: Correct return type of cpu_power_is_cpu_online in cpufreq Laura Abbott
2016-10-20 8:12 ` Shilpasri G Bhat
2016-10-24 15:11 ` Thomas Renninger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).