From: Peter Rosin <peda@axentia.se>
To: Neil Armstrong <narmstrong@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wei Chen <Wei.Chen@csr.com>, Roland Stigge <stigge@antcom.de>,
Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC PATCH] pinctrl: Add SX150X GPIO Extender Pinctrl Driver
Date: Tue, 6 Sep 2016 12:43:28 +0200 [thread overview]
Message-ID: <3922b85b-1072-6770-c8d7-58a68ecc290e@axentia.se> (raw)
In-Reply-To: <44e8d692-832f-fbbf-2930-0cd7c140a754@baylibre.com>
On 2016-09-06 10:20, Neil Armstrong wrote:
> Hi Linus, Peter,
>
> On 09/06/2016 08:44 AM, Peter Rosin wrote:
>> I intend to test this, but it might be a couple of days. I need
>> to bring the damn thing out of the closet and find the right
>> cables etc etc. And I of course have other stuff to do as well...
>
> Is it a DT only platform you intent to test with ? In this case the current version is OK.
Yes, it's DT-only, but I don't expect it to be compatible as I linked
the wrong patch, see below...
*snip*
>> No, we have not, because we depend on yet to be upstreamed drivers
>> for all of our boards, sometimes written by us, sometimes from
>> the CPU vendor. For this driver, we were using a rejected patch
>> to configure the pins from DT in the gpio driver written by
>> Wei Chen [1]
>
> Actually it seems the patch was accepted, but it is not enough to handle
> DT completely since the gpio base is incorrect, this was the subject
> of my previous patch [2], make is DT compliant even for IRQ management.
> But having a pinctrl version seens far more reasonable.
Oh crap, wrong link... Here's a better one:
https://patchwork.kernel.org/patch/5437921/
>> One thing I noted at the very end of the patch was that I on
>> first glance did not see any i2c_del_driver call, maybe use the
>> module_i2c_driver macro?
>
> Well, it's not present in the gpio version and since it manages IRQs, I assume it was
> decided to not use is as a module since it's needed to attach very early.
I just noted the omission, someone else will shirley know better than
me about what to do about it...
(BTW, we're not using interrupts)
Cheers,
Peter
next prev parent reply other threads:[~2016-09-06 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 13:11 [RFC PATCH] pinctrl: Add SX150X GPIO Extender Pinctrl Driver Neil Armstrong
2016-09-05 22:47 ` Linus Walleij
2016-09-06 6:44 ` Peter Rosin
2016-09-06 8:20 ` Neil Armstrong
2016-09-06 10:43 ` Peter Rosin [this message]
2016-09-07 22:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3922b85b-1072-6770-c8d7-58a68ecc290e@axentia.se \
--to=peda@axentia.se \
--cc=Wei.Chen@csr.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=stigge@antcom.de \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).