* [PATCH] dt-bindings: soc: samsung: usi: refer to dtschema for children
@ 2022-02-08 19:41 Krzysztof Kozlowski
2022-02-11 16:04 ` Sam Protsenko
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-08 19:41 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Alim Akhtar, Sam Protsenko,
devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
Explicitly reference the dtschema for USI children implementing specific
serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
so it will be provided later.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
.../bindings/soc/samsung/exynos-usi.yaml | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
index 58f2e9d8bb0e..f3aae7e0e2e6 100644
--- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
@@ -18,11 +18,7 @@ description: |
selects which particular function will be used.
Refer to next bindings documentation for information on protocol subnodes that
- can exist under USI node:
-
- [1] Documentation/devicetree/bindings/serial/samsung_uart.yaml
- [2] Documentation/devicetree/bindings/i2c/i2c-exynos5.txt
- [3] Documentation/devicetree/bindings/spi/spi-samsung.txt
+ can exist under USI node.
properties:
$nodename:
@@ -75,10 +71,17 @@ properties:
This property is optional.
patternProperties:
- # All other properties should be child nodes
- "^(serial|spi|i2c)@[0-9a-f]+$":
+ "^i2c@[0-9a-f]+$":
+ $ref: /schemas/i2c/i2c-exynos5.yaml
+ description: Child node describing underlying I2C
+
+ "^serial@[0-9a-f]+$":
+ $ref: /schemas/serial/samsung_uart.yaml
+ description: Child node describing underlying UART/serial
+
+ "^spi@[0-9a-f]+$":
type: object
- description: Child node describing underlying USI serial protocol
+ description: Child node describing underlying SPI
required:
- compatible
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: soc: samsung: usi: refer to dtschema for children
2022-02-08 19:41 [PATCH] dt-bindings: soc: samsung: usi: refer to dtschema for children Krzysztof Kozlowski
@ 2022-02-11 16:04 ` Sam Protsenko
2022-02-11 16:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Sam Protsenko @ 2022-02-11 16:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On Tue, 8 Feb 2022 at 21:41, Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Explicitly reference the dtschema for USI children implementing specific
> serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
> so it will be provided later.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> .../bindings/soc/samsung/exynos-usi.yaml | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> index 58f2e9d8bb0e..f3aae7e0e2e6 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
> @@ -18,11 +18,7 @@ description: |
> selects which particular function will be used.
>
> Refer to next bindings documentation for information on protocol subnodes that
> - can exist under USI node:
This whole paragraph doesn't make much sense now, because the doc
links it refers to are removed in this patch. Maybe it's better to
just remove the whole paragraph?
> -
> - [1] Documentation/devicetree/bindings/serial/samsung_uart.yaml
> - [2] Documentation/devicetree/bindings/i2c/i2c-exynos5.txt
> - [3] Documentation/devicetree/bindings/spi/spi-samsung.txt
> + can exist under USI node.
>
> properties:
> $nodename:
> @@ -75,10 +71,17 @@ properties:
> This property is optional.
>
> patternProperties:
> - # All other properties should be child nodes
> - "^(serial|spi|i2c)@[0-9a-f]+$":
> + "^i2c@[0-9a-f]+$":
> + $ref: /schemas/i2c/i2c-exynos5.yaml
> + description: Child node describing underlying I2C
> +
> + "^serial@[0-9a-f]+$":
> + $ref: /schemas/serial/samsung_uart.yaml
> + description: Child node describing underlying UART/serial
> +
> + "^spi@[0-9a-f]+$":
> type: object
> - description: Child node describing underlying USI serial protocol
> + description: Child node describing underlying SPI
>
> required:
> - compatible
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: soc: samsung: usi: refer to dtschema for children
2022-02-11 16:04 ` Sam Protsenko
@ 2022-02-11 16:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-11 16:46 UTC (permalink / raw)
To: Sam Protsenko
Cc: Rob Herring, Alim Akhtar, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
On 11/02/2022 17:04, Sam Protsenko wrote:
> On Tue, 8 Feb 2022 at 21:41, Krzysztof Kozlowski
> <krzysztof.kozlowski@canonical.com> wrote:
>>
>> Explicitly reference the dtschema for USI children implementing specific
>> serial protocol (I2C, SPI, UART). The SPI schema is not yet accepted,
>> so it will be provided later.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> ---
>> .../bindings/soc/samsung/exynos-usi.yaml | 19 +++++++++++--------
>> 1 file changed, 11 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
>> index 58f2e9d8bb0e..f3aae7e0e2e6 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml
>> @@ -18,11 +18,7 @@ description: |
>> selects which particular function will be used.
>>
>> Refer to next bindings documentation for information on protocol subnodes that
>> - can exist under USI node:
>
> This whole paragraph doesn't make much sense now, because the doc
> links it refers to are removed in this patch. Maybe it's better to
> just remove the whole paragraph?
Yes, I will drop it.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-11 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-08 19:41 [PATCH] dt-bindings: soc: samsung: usi: refer to dtschema for children Krzysztof Kozlowski
2022-02-11 16:04 ` Sam Protsenko
2022-02-11 16:46 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).