linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] matroxfb and mga XF4 driver coexistence...
@ 2001-04-12 13:01 Petr Vandrovec
  2001-04-12 13:04 ` Rafael E. Herrera
  0 siblings, 1 reply; 7+ messages in thread
From: Petr Vandrovec @ 2001-04-12 13:01 UTC (permalink / raw)
  To: Chris Meadors; +Cc: alan, torvalds, linux-kernel, linux-fbdev

On 11 Apr 01 at 14:55, Chris Meadors wrote:
> 
> I would like to see this fixed as much as anyone (even complained to the
> XFree people from SuSE last ALS).  But I don't think the fix should be in
> the kernel.  XF4 needs to be fixed.  The problem doesn't just effect the
> maxtroxfb, but also the vgacon video mode selection.

But only users using matroxfb complains to me and/or to linux-kernel ;-)
You know, it worked last week, but it does not work anymore today. And
only thing I changed was kernel. So it must be in kernel...
 
> If I put anything other than "normal" or "extended" in the "vga=" line of
> my lilo.conf the machine starts okay, but upon exiting X bad stuff

It is first time I see that other drivers than mga one has troubles.
 
> I don't use the matroxfb driver so this patch wouldn't help me, and is
> also why I say XFree 4.0 needs to be fixed.

Buy matrox and use matroxfb. It will fix problem for you, then...
                                                Petr Vandrovec
                                                vandrove@vc.cvut.cz
                                                

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] matroxfb and mga XF4 driver coexistence...
@ 2001-04-11 18:11 Petr Vandrovec
  2001-04-11 18:55 ` Chris Meadors
  0 siblings, 1 reply; 7+ messages in thread
From: Petr Vandrovec @ 2001-04-11 18:11 UTC (permalink / raw)
  To: alan, torvalds; +Cc: linux-kernel, linux-fbdev

Hi,
   Alan, Linus, please apply this patch to matroxfb. It fixes complaints
from people that screen is black after they exit from X back to console.
Matrox driver does not know that it should return hardware state back to
initial state after switch, but matroxfb relies on that (XF3 did that...).
So now it reprograms hardware always from scratch...
					Thanks,
						Petr Vandrovec
						vandrove@vc.cvut.cz

diff -urdN linux/drivers/video/matrox/matroxfb_DAC1064.c linux/drivers/video/matrox/matroxfb_DAC1064.c
--- linux/drivers/video/matrox/matroxfb_DAC1064.c	Tue Apr 10 22:56:19 2001
+++ linux/drivers/video/matrox/matroxfb_DAC1064.c	Wed Apr 11 11:45:50 2001
@@ -418,7 +418,12 @@
 	outDAC1064(PMINFO DAC1064_XSYSPLLM, hw->DACclk[3]);
 	outDAC1064(PMINFO DAC1064_XSYSPLLN, hw->DACclk[4]);
 	outDAC1064(PMINFO DAC1064_XSYSPLLP, hw->DACclk[5]);
-	if (!oldhw || memcmp(hw->DACreg, oldhw->DACreg, sizeof(MGA1064_DAC_regs))) {
+	/*
+	 * We must ALWAYS reprogram hardware due to broken XF4 matrox drivers...
+	 *
+	 * if (!oldhw || memcmp(hw->DACreg, oldhw->DACreg, sizeof(MGA1064_DAC_regs))) 
+	 */
+	{
 		unsigned int i;
 
 		for (i = 0; i < sizeof(MGA1064_DAC_regs); i++) {

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2001-04-12 19:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-04-12 13:01 [PATCH] matroxfb and mga XF4 driver coexistence Petr Vandrovec
2001-04-12 13:04 ` Rafael E. Herrera
2001-04-12 13:28   ` Chris Meadors
2001-04-12 18:53     ` [lkml]Re: " thunder7
2001-04-12 19:53       ` Chris Meadors
  -- strict thread matches above, loose matches on Subject: below --
2001-04-11 18:11 Petr Vandrovec
2001-04-11 18:55 ` Chris Meadors

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).