* 2.4.20pre5 trivial assembler warning fix for pci-pc.c
@ 2002-09-05 20:22 Andreas Steinmetz
2002-09-05 23:26 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Steinmetz @ 2002-09-05 20:22 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 135 bytes --]
trivial fix for "Warning: indirect lcall without `*'" assembler warnings
attached.
--
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH
[-- Attachment #2: pci-pc.c.diff --]
[-- Type: text/plain, Size: 2146 bytes --]
--- arch/i386/kernel/pci-pc.c.orig 2002-09-05 22:16:40.000000000 +0200
+++ arch/i386/kernel/pci-pc.c 2002-09-05 22:18:00.000000000 +0200
@@ -589,7 +589,7 @@
unsigned long flags;
__save_flags(flags); __cli();
- __asm__("lcall (%%edi); cld"
+ __asm__("lcall *(%%edi); cld"
: "=a" (return_code),
"=b" (address),
"=c" (length),
@@ -630,7 +630,7 @@
__save_flags(flags); __cli();
__asm__(
- "lcall (%%edi); cld\n\t"
+ "lcall *(%%edi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -675,7 +675,7 @@
unsigned short bx;
unsigned short ret;
- __asm__("lcall (%%edi); cld\n\t"
+ __asm__("lcall *(%%edi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -704,7 +704,7 @@
switch (len) {
case 1:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -716,7 +716,7 @@
"S" (&pci_indirect));
break;
case 2:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -728,7 +728,7 @@
"S" (&pci_indirect));
break;
case 4:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -759,7 +759,7 @@
switch (len) {
case 1:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -771,7 +771,7 @@
"S" (&pci_indirect));
break;
case 2:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -783,7 +783,7 @@
"S" (&pci_indirect));
break;
case 4:
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
@@ -1006,7 +1006,7 @@
__asm__("push %%es\n\t"
"push %%ds\n\t"
"pop %%es\n\t"
- "lcall (%%esi); cld\n\t"
+ "lcall *(%%esi); cld\n\t"
"pop %%es\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
@@ -1039,7 +1039,7 @@
{
int ret;
- __asm__("lcall (%%esi); cld\n\t"
+ __asm__("lcall *(%%esi); cld\n\t"
"jc 1f\n\t"
"xor %%ah, %%ah\n"
"1:"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 2.4.20pre5 trivial assembler warning fix for pci-pc.c
2002-09-05 20:22 2.4.20pre5 trivial assembler warning fix for pci-pc.c Andreas Steinmetz
@ 2002-09-05 23:26 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2002-09-05 23:26 UTC (permalink / raw)
To: Andreas Steinmetz; +Cc: linux-kernel
On Thu, 2002-09-05 at 21:22, Andreas Steinmetz wrote:
> trivial fix for "Warning: indirect lcall without `*'" assembler warnings
> attached.
I've always left those because there are still old binutils around that
misassemble with the "*". One for 2.5 IMHO
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-09-05 23:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-05 20:22 2.4.20pre5 trivial assembler warning fix for pci-pc.c Andreas Steinmetz
2002-09-05 23:26 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).