linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karim Yaghmour <karim@opersys.com>
To: Pavel Machek <pavel@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH] LTT for 2.5.37 2/9: Trace driver
Date: Mon, 23 Sep 2002 11:14:47 -0400	[thread overview]
Message-ID: <3D8F2FE7.528593EF@opersys.com> (raw)
In-Reply-To: 20020922003837.A35@toy.ucw.cz


Pavel Machek wrote:
> Hi!
> 
> > +/*  Driver */
> > +static int           sMajorNumber;           /* Major number of the tracer */
> > +static int           sOpenCount;             /* Number of times device is open */
> > +/*  Locking */
> 
> Why *s*OpenCount? Some creeping infection by hungarian notation?

"static" as opposed 'l' for "local" elsewhere in the code, but you're looking
at code that is going to change to fit the usual kernel coding style. So all
those S's and L's will go away ;)

Karim

===================================================
                 Karim Yaghmour
               karim@opersys.com
      Embedded and Real-Time Linux Expert
===================================================

  reply	other threads:[~2002-09-23 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-21 23:14 [PATCH] LTT for 2.5.37 2/9: Trace driver Karim Yaghmour
2002-09-22  0:38 ` Pavel Machek
2002-09-23 15:14   ` Karim Yaghmour [this message]
2002-09-23 18:34   ` Richard B. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D8F2FE7.528593EF@opersys.com \
    --to=karim@opersys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@shafik.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).