From: "Richard B. Johnson" <root@chaos.analogic.com>
To: Pavel Machek <pavel@suse.cz>
Cc: Karim Yaghmour <karim@opersys.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH] LTT for 2.5.37 2/9: Trace driver
Date: Mon, 23 Sep 2002 14:34:27 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.3.95.1020923142959.6231A-100000@chaos.analogic.com> (raw)
In-Reply-To: <20020922003837.A35@toy.ucw.cz>
On Sun, 22 Sep 2002, Pavel Machek wrote:
> Hi!
>
> > +/* Driver */
> > +static int sMajorNumber; /* Major number of the tracer */
> > +static int sOpenCount; /* Number of times device is open */
> > +/* Locking */
>
> Why *s*OpenCount? Some creeping infection by hungarian notation?
>
int YesItLooksAsThoughSomeOfThisHasCreptIntoTheKernelAsWell = TRUE;
Methinks it started in a BusLogic driver and wasn't stamped out
before it spread and infected everything else!
Cheers,
Dick Johnson
Penguin : Linux version 2.4.18 on an i686 machine (797.90 BogoMips).
The US military has given us many words, FUBAR, SNAFU, now ENRON.
Yes, top management were graduates of West Point and Annapolis.
prev parent reply other threads:[~2002-09-23 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-21 23:14 [PATCH] LTT for 2.5.37 2/9: Trace driver Karim Yaghmour
2002-09-22 0:38 ` Pavel Machek
2002-09-23 15:14 ` Karim Yaghmour
2002-09-23 18:34 ` Richard B. Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.3.95.1020923142959.6231A-100000@chaos.analogic.com \
--to=root@chaos.analogic.com \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).