From: Jeff Garzik <jgarzik@pobox.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Andrew V. Savochkin" <saw@saw.sw.com.sg>,
cgl_discussion mailing list <cgl_discussion@osdl.org>,
evlog mailing list <evlog-developers@lists.sourceforge.net>,
"ipslinux (Keith Mitchell)" <ipslinux@us.ibm.com>,
Linus Torvalds <torvalds@home.transmeta.com>,
Hien Nguyen <hien@us.ibm.com>,
James Keniston <kenistoj@us.ibm.com>,
Mike Sullivan <sullivam@us.ibm.com>
Subject: Re: [PATCH-RFC] README 1ST - New problem logging macros (2.5.38)
Date: Tue, 24 Sep 2002 02:11:56 -0400 [thread overview]
Message-ID: <3D90022C.3060300@pobox.com> (raw)
In-Reply-To: 20020924055657.C968F2C0A6@lists.samba.org
Rusty Russell wrote:
> In message <3D8FD0A9.1010906@pobox.com> you write:
>
>>>@@ -325,7 +326,8 @@
>>> while(inb(cmd_ioaddr) && --wait >= 0);
>>> #ifndef final_version
>>> if (wait < 0)
>>>- printk(KERN_ALERT "eepro100: wait_for_cmd_done timeout!\n");
>>>+ problem(LOG_ALERT, "eepro100: wait_for_cmd_done timeout!",
>>>+ detail(ioaddr, "%lx", cmd_ioaddr));
>>
>>bloat, the ioaddr can easily be deduced
>
>
> No! That's *exactly* the problem: you see:
> eepro100: wait_for_cmd_done timeout!
>
> in your logs, now *which* of the 5 eepro100 cards was it?
>
> wait_for_cmd_done(long cmd_ioaddr) should take a 'struct net_device *'
> and use net_problem, then no details needed.
right, that's a bug, it needs struct net_device * like the standard
Becker style.
>>>- printk (KERN_ERR "eepro100: cannot reserve MMIO region\n");
>>>+ pci_problem(LOG_ERR, pdev, "eepro100: cannot reserve MMIO regio
>>
> n");
>
>>bloat, no advantage over printk
>
>
> Now, which of those 5 cards was it again?
Another bug, this driver should be using pci_request_regions() which
prints that stuff out :)
Does IBM want to submit a patch that cleans up these problems, and makes
the existing event logging more standard [and is compatible with
existing 2.4 and 2.5 kernels]?
As an aside, changing all those printks also introduces a _huge_ PITA
for driver developers porting drivers back and forth between 2.4 and 2.5.
Jeff
next prev parent reply other threads:[~2002-09-24 6:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-24 1:55 [PATCH-RFC] README 1ST - New problem logging macros (2.5.38) Larry Kessler
2002-09-24 2:40 ` Jeff Garzik
2002-09-24 5:55 ` Rusty Russell
2002-09-24 6:11 ` Jeff Garzik [this message]
2002-09-24 6:58 ` Rusty Russell
2002-09-24 5:15 ` Greg KH
2002-09-24 5:28 ` Jeff Garzik
2002-09-26 18:56 ` Larry Kessler
2002-09-26 19:38 ` Rik van Riel
2002-09-26 20:01 ` Larry Kessler
2002-09-26 18:41 ` Rob Landley
2002-09-24 5:58 ` Greg KH
2002-09-24 16:32 ` Patrick Mochel
2002-09-24 8:36 ` Andrey Savochkin
2002-09-24 4:49 [PATCH-RFC] " Larry Kessler
2002-09-24 12:58 ` Denis Vlasenko
2002-09-24 13:59 ` Gerhard Mack
2002-09-24 22:38 ` Thunder from the hill
2002-09-24 4:56 Jeff Garzik
2002-09-24 14:04 Randal, Phil
2002-09-24 14:15 ` Sven Koch
2002-09-26 15:43 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D90022C.3060300@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=cgl_discussion@osdl.org \
--cc=evlog-developers@lists.sourceforge.net \
--cc=hien@us.ibm.com \
--cc=ipslinux@us.ibm.com \
--cc=kenistoj@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=saw@saw.sw.com.sg \
--cc=sullivam@us.ibm.com \
--cc=torvalds@home.transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).