archive mirror
 help / color / mirror / Atom feed
From: Greg Ungerer <>
To: Matthew Wilcox <>
Subject: Re: [PATCH]: 2.5.38uc1 (MMU-less support)
Date: Thu, 26 Sep 2002 12:35:36 +1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Matthew,

Some more comments on the ethernet driver.

BTW, the original this came from is in the kernel tree
at arch/ppc/8xx_io/fec.c.

Matthew Wilcox wrote:
> Motorola 5272 ethernet driver:
> * In, let's conditionalise it on CONFIG_PPC or something
> * Can you use module_init() so it doesn't need an entry in Space.c?

I don't think this will work. This is not a device that can be
determined to be present like a PCI device. It is more like an
ISA device, it needs to be probed to figure out if it is really
there. I can't see any way not to use Space.c for non-auto-detectable
type devices... (Offcourse I could be missing something :-)

> * You're defining CONFIG_* variables in the .c file.  I don't know whether
>   this is something we're still trying to avoid doing ... Greg, you seem
>   to be CodingStyle enforcer, what's the word?

I missed this the first time through :-)
I am not sure what you mean, CodingStyle enforcer?
Can you elaborate for me?


Greg Ungerer  --  Chief Software Wizard        EMAIL:
SnapGear Pty Ltd                               PHONE:    +61 7 3435 2888
825 Stanley St,                                  FAX:    +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia              WEB:

  parent reply	other threads:[~2002-09-26  2:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-25 14:19 Matthew Wilcox
2002-09-25 15:33 ` Greg Ungerer
2002-09-25 15:43 ` Greg KH
2002-09-26  2:35 ` Greg Ungerer [this message]
2002-09-26  3:19   ` Randy Dunlap
2002-09-26  4:29     ` Greg Ungerer
2002-09-26 14:56   ` Matthew Wilcox
2002-09-27  4:09     ` Greg Ungerer
2002-09-26  6:07 ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2002-09-25  3:48 Greg Ungerer
2002-09-25 15:45 ` Greg KH
2002-09-25 23:57   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \
    --subject='Re: [PATCH]: 2.5.38uc1 (MMU-less support)' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).