linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] 2.4.20rc1 compile fix for t128.c
@ 2002-11-04 13:37 Andreas Steinmetz
  2002-11-04 14:23 ` Alan Cox
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Steinmetz @ 2002-11-04 13:37 UTC (permalink / raw)
  To: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 108 bytes --]

The attached patch fixes a section type conflict error.
-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

[-- Attachment #2: t128.c.diff --]
[-- Type: text/plain, Size: 319 bytes --]

--- ./drivers/scsi/t128.c.orig	2002-11-04 14:21:30.000000000 +0100
+++ ./drivers/scsi/t128.c	2002-11-04 14:21:47.000000000 +0100
@@ -145,7 +145,7 @@
 static const struct signature {
 	const char *string;
 	int offset;
-} signatures[] __initdata = {
+} signatures[] = {
 	{"TSROM: SCSI BIOS, Version 1.12", 0x36},
 };
 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] 2.4.20rc1 compile fix for t128.c
  2002-11-04 14:23 ` Alan Cox
@ 2002-11-04 14:16   ` Andreas Steinmetz
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Steinmetz @ 2002-11-04 14:16 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linux Kernel Mailing List

[forgot to cc lkml]

Alan Cox wrote:
> On Mon, 2002-11-04 at 13:37, Andreas Steinmetz wrote:
> 
>>The attached patch fixes a section type conflict error.
> 
> 
> Which compiler is showing this problem ?
> 

gcc 3.2

> 
>>--- ./drivers/scsi/t128.c.orig	2002-11-04 14:21:30.000000000 +0100
>>+++ ./drivers/scsi/t128.c	2002-11-04 14:21:47.000000000 +0100
>>@@ -145,7 +145,7 @@
>> static const struct signature {
>> 	const char *string;
>> 	int offset;
>>-} signatures[] __initdata = {
>>+} signatures[] = {
>> 	{"TSROM: SCSI BIOS, Version 1.12", 0x36},
> 
> 
> Far better to lose the const
> 

any way you please.

> 

-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] 2.4.20rc1 compile fix for t128.c
  2002-11-04 13:37 [PATCH] 2.4.20rc1 compile fix for t128.c Andreas Steinmetz
@ 2002-11-04 14:23 ` Alan Cox
  2002-11-04 14:16   ` Andreas Steinmetz
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2002-11-04 14:23 UTC (permalink / raw)
  To: Andreas Steinmetz; +Cc: Linux Kernel Mailing List

On Mon, 2002-11-04 at 13:37, Andreas Steinmetz wrote:
> The attached patch fixes a section type conflict error.

Which compiler is showing this problem ?

> --- ./drivers/scsi/t128.c.orig	2002-11-04 14:21:30.000000000 +0100
> +++ ./drivers/scsi/t128.c	2002-11-04 14:21:47.000000000 +0100
> @@ -145,7 +145,7 @@
>  static const struct signature {
>  	const char *string;
>  	int offset;
> -} signatures[] __initdata = {
> +} signatures[] = {
>  	{"TSROM: SCSI BIOS, Version 1.12", 0x36},

Far better to lose the const


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-11-04 14:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-04 13:37 [PATCH] 2.4.20rc1 compile fix for t128.c Andreas Steinmetz
2002-11-04 14:23 ` Alan Cox
2002-11-04 14:16   ` Andreas Steinmetz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).