archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <>
To: Jens Axboe <>
Cc: Zwane Mwaikambo <>,
	Linux Kernel <>
Subject: Re: Badness in as-iosched:1210
Date: Fri, 25 Apr 2003 13:04:07 +1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Jens Axboe wrote:

>On Fri, Apr 25 2003, Nick Piggin wrote:
>>Jens Axboe wrote:
>>>On Thu, Apr 24 2003, Nick Piggin wrote:
>>>>Zwane Mwaikambo wrote:
>>>>>I'm not sure wether you want this, it was during error handling from the 
>>>>>HBA driver (source was disk error).
>>>>>scsi1: ERROR on channel 0, id 3, lun 0, CDB: Read (10) 00 00 7f de 60 00 
>>>>>00 80 00 Info fld=0x7fdeb2, Current sdd: sense key Medium Error
>>>>>Additional sense: Unrecovered read error
>>>>>end_request: I/O error, dev sdd, sector 8380032
>>>>>Badness in as_add_request at drivers/block/as-iosched.c:1210
>>>>Thanks I'll have a look.
>>>The debug check looks broken, request could have come from somewhere
>>>else than the block pool.
>>Thats right. I thought these requests would all be
>>!blk_fs_request()s though. It should be only the debug
>>checks which are wrong.
>Exactly, the rest looks ok, the debug trigger is wrong :). The
>add_request() strategy is the entry point for all types of requests, not
>just blk_fs_request()
No but it is as_insert_request which is that entry point. It
should only calls as_add_request for a blk_fs_request.

  reply	other threads:[~2003-04-25  2:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23  3:04 Badness in as-iosched:1210 Zwane Mwaikambo
2003-04-24  8:31 ` Nick Piggin
2003-04-24  8:47   ` Jens Axboe
2003-04-24 17:09     ` Nick Piggin
2003-04-24 17:32       ` Jens Axboe
2003-04-25  3:04         ` Nick Piggin [this message]
2003-04-25  6:23           ` Jens Axboe
2003-04-25  8:28             ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).