archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <>
To: Jens Axboe <>
Cc: Zwane Mwaikambo <>,
	Linux Kernel <>
Subject: Re: Badness in as-iosched:1210
Date: Fri, 25 Apr 2003 18:28:28 +1000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Jens Axboe wrote:

>On Fri, Apr 25 2003, Nick Piggin wrote:
>>Jens Axboe wrote:
>>>On Fri, Apr 25 2003, Nick Piggin wrote:
>>>Exactly, the rest looks ok, the debug trigger is wrong :). The
>>>add_request() strategy is the entry point for all types of requests, not
>>>just blk_fs_request()
>>No but it is as_insert_request which is that entry point. It
>>should only calls as_add_request for a blk_fs_request.
>Oh I see, yes you are right, I should have looked closer (I just assumed
>it was your elevator_add_req_fn, your naming is a bit funny :)
>The debug check is still a bit silly, and there's nothing that stops it
>from being wrong. So I'd still suggest to kill it.
Well the debug check is supposed to catch drivers which aren't
behaving nicely or if the reference counting is broken somewhere.

I suppose now that blk_put_request is being used to call
elv_completed_request then it should be pretty safe, right?

So I'll remove the debug stuff then

      reply	other threads:[~2003-04-25  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23  3:04 Badness in as-iosched:1210 Zwane Mwaikambo
2003-04-24  8:31 ` Nick Piggin
2003-04-24  8:47   ` Jens Axboe
2003-04-24 17:09     ` Nick Piggin
2003-04-24 17:32       ` Jens Axboe
2003-04-25  3:04         ` Nick Piggin
2003-04-25  6:23           ` Jens Axboe
2003-04-25  8:28             ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).