From: Jeff Garzik <jgarzik@pobox.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [BK PATCH] irqreturn_t unsignedness
Date: Sat, 26 Apr 2003 00:17:20 -0400 [thread overview]
Message-ID: <3EAA0850.8050600@pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: irq-return-2.5.txt --]
[-- Type: text/plain, Size: 788 bytes --]
Linus, please do a
bk pull bk://kernel.bkbits.net/jgarzik/irq-return-2.5
This will update the following files:
include/linux/interrupt.h | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
through these ChangeSets:
<jgarzik@redhat.com> (03/04/25 1.1252)
s/int/unsigned int/ for irqreturn_t definition.
Pragmatic change. Would prefer to make it now rather than later.
Though sign-extension problems are unlikely, I prefer 'unsigned int'
because it occasionally generates better code, and 'int' occasionally
generates sub-optimal code (because the compiler cannot rule out
negative values during optimization).
Better still would be to indicate the variable's true range
via _Bool: zero, and non-zero, but I did not make that change
here.
reply other threads:[~2003-04-26 4:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EAA0850.8050600@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).