* 2.5.69-bk7: multiple definition of `usb_gadget_get_string' @ 2003-05-12 20:58 Adrian Bunk 2003-05-12 21:11 ` Greg KH 0 siblings, 1 reply; 5+ messages in thread From: Adrian Bunk @ 2003-05-12 20:58 UTC (permalink / raw) To: David Brownell, Greg KH; +Cc: linux-kernel <-- snip --> ... ld -m elf_i386 -r -o drivers/usb/gadget/built-in.o drivers/usb/gadget/net2280.o drivers/usb/gadget/g_zero.o drivers/usb/gadget/g_ether.o drivers/usb/gadget/g_ether.o(.text+0x1f60): In function `usb_gadget_get_string': : multiple definition of `usb_gadget_get_string' drivers/usb/gadget/g_zero.o(.text+0x0): first defined here make[2]: *** [drivers/usb/gadget/built-in.o] Error 1 <-- snip --> cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.69-bk7: multiple definition of `usb_gadget_get_string' 2003-05-12 20:58 2.5.69-bk7: multiple definition of `usb_gadget_get_string' Adrian Bunk @ 2003-05-12 21:11 ` Greg KH 2003-05-13 0:06 ` David Brownell 0 siblings, 1 reply; 5+ messages in thread From: Greg KH @ 2003-05-12 21:11 UTC (permalink / raw) To: Adrian Bunk; +Cc: David Brownell, linux-kernel On Mon, May 12, 2003 at 10:58:48PM +0200, Adrian Bunk wrote: > <-- snip --> > > ... > ld -m elf_i386 -r -o drivers/usb/gadget/built-in.o > drivers/usb/gadget/net2280.o drivers/usb/gadget/g_zero.o > drivers/usb/gadget/g_ether.o > drivers/usb/gadget/g_ether.o(.text+0x1f60): In function > `usb_gadget_get_string': > : multiple definition of `usb_gadget_get_string' > drivers/usb/gadget/g_zero.o(.text+0x0): first defined here > make[2]: *** [drivers/usb/gadget/built-in.o] Error 1 I don't think that g_zero and g_ether are allowed to be built into the kernel at the same time. David, want to send a patch to fix the Kconfig file to prevent this? thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.69-bk7: multiple definition of `usb_gadget_get_string' 2003-05-12 21:11 ` Greg KH @ 2003-05-13 0:06 ` David Brownell 2003-05-13 15:35 ` Roman Zippel 2003-05-13 20:09 ` Greg KH 0 siblings, 2 replies; 5+ messages in thread From: David Brownell @ 2003-05-13 0:06 UTC (permalink / raw) To: Greg KH; +Cc: Adrian Bunk, linux-kernel [-- Attachment #1: Type: text/plain, Size: 728 bytes --] Greg KH wrote: > On Mon, May 12, 2003 at 10:58:48PM +0200, Adrian Bunk wrote: >>`usb_gadget_get_string': >>: multiple definition of `usb_gadget_get_string' >>drivers/usb/gadget/g_zero.o(.text+0x0): first defined here >>make[2]: *** [drivers/usb/gadget/built-in.o] Error 1 > > > I don't think that g_zero and g_ether are allowed to be built into the > kernel at the same time. David, want to send a patch to fix the Kconfig > file to prevent this? Yes, just one: there's only one upstream USB connector, it can only have one driver. Patch attached. Seems like the xconfig/menuconfig coredumps I previously saw with tristate choice/endchoice are now gone ... or at least they don't show up with this many choices! - Dave [-- Attachment #2: kconf.patch --] [-- Type: text/plain, Size: 1306 bytes --] --- 1.2/drivers/usb/gadget/Kconfig Tue May 6 05:34:53 2003 +++ edited/drivers/usb/gadget/Kconfig Mon May 12 16:56:45 2003 @@ -35,9 +35,8 @@ # # USB Peripheral Controller Support # -# FIXME convert to tristate choice when "choice" behaves as specified -# -comment "USB Peripheral Controller Support" +choice + prompt "USB Peripheral Controller Support" depends on USB_GADGET config USB_NET2280 @@ -55,19 +54,17 @@ dynamically linked module called "net2280" and force all gadget drivers to also be dynamically linked. +endchoice + # # USB Gadget Drivers # -# FIXME only one of these may be statically linked; choice/endchoice. -# -comment "USB Gadget Drivers" +choice + prompt "USB Gadget Drivers" depends on USB_GADGET + default USB_ETH -# FIXME want better dependency/config approach for drivers. with only -# two knobs to tweak (driver y/m/n, and a hardware symbol) there's no -# good excuse for Kconfig to cause such trouble here. there are clear -# bugs (coredumps, multiple choices enabled, and more) in its (boolean) -# "choice" logic too ... +# FIXME want a cleaner dependency/config approach for drivers. config USB_ZERO tristate "Gadget Zero (DEVELOPMENT)" @@ -149,5 +146,7 @@ bool depends on USB_ETH && USB_SA1100 default y + +endchoice # endmenuconfig ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.69-bk7: multiple definition of `usb_gadget_get_string' 2003-05-13 0:06 ` David Brownell @ 2003-05-13 15:35 ` Roman Zippel 2003-05-13 20:09 ` Greg KH 1 sibling, 0 replies; 5+ messages in thread From: Roman Zippel @ 2003-05-13 15:35 UTC (permalink / raw) To: David Brownell; +Cc: Greg KH, Adrian Bunk, linux-kernel Hi, On Mon, 12 May 2003, David Brownell wrote: > Seems like the xconfig/menuconfig coredumps I previously > saw with tristate choice/endchoice are now gone ... or at > least they don't show up with this many choices! There might be problems with choices, which have no visible values, I'll have to check this. Please report such problems, otherwise I can't fix them. bye, Roman ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 2.5.69-bk7: multiple definition of `usb_gadget_get_string' 2003-05-13 0:06 ` David Brownell 2003-05-13 15:35 ` Roman Zippel @ 2003-05-13 20:09 ` Greg KH 1 sibling, 0 replies; 5+ messages in thread From: Greg KH @ 2003-05-13 20:09 UTC (permalink / raw) To: David Brownell; +Cc: Adrian Bunk, linux-kernel On Mon, May 12, 2003 at 05:06:29PM -0700, David Brownell wrote: > Greg KH wrote: > >On Mon, May 12, 2003 at 10:58:48PM +0200, Adrian Bunk wrote: > >>`usb_gadget_get_string': > >>: multiple definition of `usb_gadget_get_string' > >>drivers/usb/gadget/g_zero.o(.text+0x0): first defined here > >>make[2]: *** [drivers/usb/gadget/built-in.o] Error 1 > > > > > >I don't think that g_zero and g_ether are allowed to be built into the > >kernel at the same time. David, want to send a patch to fix the Kconfig > >file to prevent this? > > Yes, just one: there's only one upstream USB connector, > it can only have one driver. Patch attached. > > Seems like the xconfig/menuconfig coredumps I previously > saw with tristate choice/endchoice are now gone ... or at > least they don't show up with this many choices! Applied, thanks. greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-05-13 20:02 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-05-12 20:58 2.5.69-bk7: multiple definition of `usb_gadget_get_string' Adrian Bunk 2003-05-12 21:11 ` Greg KH 2003-05-13 0:06 ` David Brownell 2003-05-13 15:35 ` Roman Zippel 2003-05-13 20:09 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).