From: Jari Ruusu <jari.ruusu@pp.inet.fi>
To: Andries.Brouwer@cwi.nl
Cc: akpm@digeo.com, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH] cryptoloop
Date: Thu, 03 Jul 2003 14:21:29 +0300 [thread overview]
Message-ID: <3F0411B9.9E11022D@pp.inet.fi> (raw)
In-Reply-To: UTC200307021844.h62IiIQ19914.aeb@smtp.cwi.nl
Andries.Brouwer@cwi.nl wrote:
> akpm:
> > You'll note that loop.c goes from (page/offset/len) to (addr/len),
> > and this transfer function then immediately goes from (addr,len)
> > to (page/offset/len). That's rather silly ..
>
> Changing that would kill all existing modules that use the loop device.
>
> Maybe nobody cares. Then we can do so in a subsequent patch.
I care. Please don't break the transfer function prototype.
I don't know if you guys have realized it or not, but cryptoloop+cryptoapi
is the slowest possible loop crypto implementation on the planet. Before you
guys sacrifice loop performance with cryptoloop only stuff, you may want to
do google search for "loop-AES" (twice as fast on most modern boxes) and
choose to preserve fast interfaces that other implementations depend on.
Regards,
Jari Ruusu <jari.ruusu@pp.inet.fi>
next prev parent reply other threads:[~2003-07-03 11:07 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-02 18:44 [PATCH] cryptoloop Andries.Brouwer
2003-07-02 19:02 ` Andrew Morton
2003-07-02 19:16 ` Linus Torvalds
2003-07-02 19:20 ` Andrew Morton
2003-07-02 19:31 ` Linus Torvalds
2003-07-03 11:21 ` Jari Ruusu [this message]
2003-07-03 15:20 ` Andrew Morton
2003-07-03 17:29 ` Jari Ruusu
2003-07-03 17:38 ` Chris Friesen
2003-07-04 7:43 ` Jari Ruusu
2003-07-04 8:44 ` Andrew Morton
2003-07-04 9:41 ` Christoph Hellwig
2003-07-05 8:41 ` Jari Ruusu
2003-07-05 8:58 ` Andrew Morton
2003-07-05 9:00 ` Andre Hedrick
2003-07-05 9:10 ` Andre Hedrick
2003-07-05 17:16 ` James Morris
2003-07-05 17:20 ` Linus Torvalds
2003-07-08 12:43 ` Christoph Hellwig
2003-07-04 9:39 ` Christoph Hellwig
2003-07-03 16:20 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2003-07-04 13:21 Andries.Brouwer
2003-07-04 13:28 ` Christoph Hellwig
2003-07-04 11:08 Andries.Brouwer
2003-07-04 12:13 ` Christoph Hellwig
2003-07-03 16:25 Andries.Brouwer
2003-07-03 16:31 ` Christoph Hellwig
2003-07-02 22:57 Andries.Brouwer
2003-07-02 22:27 Andries.Brouwer
2003-07-02 21:00 Andries.Brouwer
2003-07-02 21:06 ` Greg KH
2003-07-02 21:31 ` Andrew Morton
2003-07-03 16:23 ` Christoph Hellwig
2003-07-02 19:42 Andries.Brouwer
2003-07-02 19:58 ` Andrew Morton
2003-07-02 15:21 Andries.Brouwer
2003-07-02 17:16 ` Andrew Morton
2003-07-03 15:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F0411B9.9E11022D@pp.inet.fi \
--to=jari.ruusu@pp.inet.fi \
--cc=Andries.Brouwer@cwi.nl \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).