Re: [PATCH] cryptoloop

[Andries.Brouwer@cwi.nl]

hch to jari:

> So get your code merged. Moaning about breaking out of tree code beeing
> broken by changes when an in-kernel alternative eists doesn't help.
>
> Either try to help improving what's in the tree or shut up.


Oh, Christoph - can't you just be a tiny bit more civil.

Here is an ungoing process of merging crypto/loop code.
You are perfectly aware of that - you complained about
every single stage - the rfc patch at the start was
too large, the whitespace in the next patch was distributed
incorrectly, also the third part had terrible bugs - I forget,
maybe there was a superfluous #include.

Now that you are very aware of this ongoing effort
of merging the loop stuff that so far lived as separate
patches outside the kernel tree, how can you say
"get your code merged"? That is precisely what we are
doing right now. Slowly. Step by step.


Andrew on the other hand apparently didnt know, and commented
on something that can be improved. Excellent. For this patch #3
that comment was not relevant, but no doubt we must try and
follow his good advice in some subsequent patch. Preferably
without breaking existing user space.


Try to follow Andrew's example - nice, friendly, constructive.
It is possible to be a good coder without being abusive.

Andries