* ov511 2.6.0-test3
@ 2003-08-09 19:15 Nicolas P.
2003-08-09 21:46 ` Chromosom
2003-08-09 22:11 ` Mark McClelland
0 siblings, 2 replies; 5+ messages in thread
From: Nicolas P. @ 2003-08-09 19:15 UTC (permalink / raw)
To: linux-kernel
It is new to kernel 2.6.0-test3 :
*** Warning: "video_proc_entry" [drivers/usb/media/ov511.ko] undefined!
And documentation seems obsolete :
This driver uses the Video For Linux API. You must say Y or M to
"Video For Linux" (under Character Devices) to use this driver.
Information on this API and pointers to "v4l" programs may be found
on the WWW at <http://roadrunner.swansea.uk.linux.org/v4l.shtml>.
Not any more under Character Devices, isn't it ?
Regards.
Nicolas.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ov511 2.6.0-test3
2003-08-09 19:15 ov511 2.6.0-test3 Nicolas P.
@ 2003-08-09 21:46 ` Chromosom
2003-08-10 5:16 ` Stefan B
2003-08-09 22:11 ` Mark McClelland
1 sibling, 1 reply; 5+ messages in thread
From: Chromosom @ 2003-08-09 21:46 UTC (permalink / raw)
To: linux-kernel
Nicolas P. wrote:
> It is new to kernel 2.6.0-test3 :
>
> *** Warning: "video_proc_entry" [drivers/usb/media/ov511.ko] undefined!
>
Try adding this to driver/media/video/videodev.c:
(e.g. after the other EXPORT_SYMBOL lines)
void *video_proc_entry;
EXPORT_SYMBOL(video_proc_entry);
Stefan B.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ov511 2.6.0-test3
2003-08-09 19:15 ov511 2.6.0-test3 Nicolas P.
2003-08-09 21:46 ` Chromosom
@ 2003-08-09 22:11 ` Mark McClelland
1 sibling, 0 replies; 5+ messages in thread
From: Mark McClelland @ 2003-08-09 22:11 UTC (permalink / raw)
To: Nicolas P.; +Cc: linux-kernel
Nicolas P. wrote:
>It is new to kernel 2.6.0-test3 :
>
>*** Warning: "video_proc_entry" [drivers/usb/media/ov511.ko] undefined!
>
>
That's due to the removal of /proc/video and its replacement with sysfs.
I'll submit a patch for that later today.
>And documentation seems obsolete :
>
>This driver uses the Video For Linux API. You must say Y or M to
>"Video For Linux" (under Character Devices) to use this driver.
>Information on this API and pointers to "v4l" programs may be found
>on the WWW at <http://roadrunner.swansea.uk.linux.org/v4l.shtml>.
>
>
>Not any more under Character Devices, isn't it ?
>
Thanks for noticing that. I'll fix that too.
--
Mark McClelland
mark@alpha.dyndns.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ov511 2.6.0-test3
2003-08-09 21:46 ` Chromosom
@ 2003-08-10 5:16 ` Stefan B
2003-08-10 13:29 ` Mark McClelland
0 siblings, 1 reply; 5+ messages in thread
From: Stefan B @ 2003-08-10 5:16 UTC (permalink / raw)
To: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
Stefan B. wrote:
> Try adding this to driver/media/video/videodev.c:
> (e.g. after the other EXPORT_SYMBOL lines)
>
> void *video_proc_entry;
> EXPORT_SYMBOL(video_proc_entry);
>
sorry, not good; this patch should do
[-- Attachment #2: patch-2.6.0-test3-videoproc --]
[-- Type: text/plain, Size: 1091 bytes --]
diff -Nru drivers/media/video/videodev.c
--- drivers/media/video/videodev.c Sun Aug 10 07:01:27 2003
+++ drivers/media/video/videodev.c Sun Aug 10 07:05:37 2003
@@ -367,6 +367,8 @@
* Initialise video for linux
*/
+struct proc_dir_entry *video_proc_entry = NULL;
+
static int __init videodev_init(void)
{
printk(KERN_INFO "Linux video capture interface: v1.00\n");
@@ -375,11 +377,19 @@
return -EIO;
}
class_register(&video_class);
+
+ video_proc_entry = create_proc_entry("video", S_IFDIR, &proc_root);
+ if (video_proc_entry)
+ video_proc_entry->owner = THIS_MODULE;
return 0;
}
static void __exit videodev_exit(void)
{
+ if (video_proc_entry)
+ remove_proc_entry("video", &proc_root);
+ video_proc_entry = NULL;
+
class_unregister(&video_class);
unregister_chrdev(VIDEO_MAJOR, VIDEO_NAME);
}
@@ -395,6 +405,7 @@
EXPORT_SYMBOL(video_exclusive_release);
EXPORT_SYMBOL(video_device_alloc);
EXPORT_SYMBOL(video_device_release);
+EXPORT_SYMBOL(video_proc_entry);
MODULE_AUTHOR("Alan Cox");
MODULE_DESCRIPTION("Device registrar for Video4Linux drivers");
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ov511 2.6.0-test3
2003-08-10 5:16 ` Stefan B
@ 2003-08-10 13:29 ` Mark McClelland
0 siblings, 0 replies; 5+ messages in thread
From: Mark McClelland @ 2003-08-10 13:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Stefan B, linux, Gerd Knorr
Stefan B wrote:
> Stefan B. wrote:
>
>> Try adding this to driver/media/video/videodev.c:
>> (e.g. after the other EXPORT_SYMBOL lines)
>>
>> void *video_proc_entry;
>> EXPORT_SYMBOL(video_proc_entry);
>
> sorry, not good; this patch should do
Unless you need the /proc support for something, an easier solution is
just to disable CONFIG_VIDEO_PROC_FS.
Gerd, did you leave that config option in on purpose (so that the broken
drivers would get noticed)?
Ps.: The ov511 sysfs conversion patch should be finished this evening.
It will be sent to Linux-USB-Devel.
--
Mark McClelland
mark@alpha.dyndns.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-08-10 13:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-08-09 19:15 ov511 2.6.0-test3 Nicolas P.
2003-08-09 21:46 ` Chromosom
2003-08-10 5:16 ` Stefan B
2003-08-10 13:29 ` Mark McClelland
2003-08-09 22:11 ` Mark McClelland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).