From: Jeff Garzik <jgarzik@pobox.com>
To: Larry McVoy <lm@bitmover.com>
Cc: davej@redhat.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] CodingStyle fixes for drm_agpsupport
Date: Mon, 11 Aug 2003 12:58:44 -0400 [thread overview]
Message-ID: <3F37CB44.5000307@pobox.com> (raw)
In-Reply-To: <20030811164012.GB858@work.bitmover.com>
Larry McVoy wrote:
> A few comments on why I don't like this patch:
> 1) It's a formatting only patch. That screws over people who are using
> BK for debugging, now when I double click on these changes I'll get
> to your cleanup patch, not the patch that was the last substantive
> change.
This is true, but at the same time, in Linux CodingStyle patches
culturally acceptable. I think the general logic is just "don't go
overboard; reformat a tiny fragment at a time."
> 2) "if (expr) statement;" really ought to be considered legit coding style.
> It's a one line "shorty" and it lets you see more of the code on a
> screen.
>
> On the other hand, the author carried things too far when they did
>
> if (expr) statement;
> else statement;
>
> that's too hard for your eyes to parse quickly IMO.
tee hee :) This is why we have Documentation/CodingStyle, for just this
type of discussion.
I actually prefer your "author carried ... too far" example, with the
reasoning: if you _must_ deviate from CodingStyle, at least don't run
the damn lines together like
if (test) foo else bar;
or
if (test) foo
else bar;
The alignment of the statements visually separates out the test more
clearly.
Jeff
next prev parent reply other threads:[~2003-08-11 17:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 15:59 [PATCH] CodingStyle fixes for drm_agpsupport davej
2003-08-11 16:40 ` Larry McVoy
2003-08-11 16:58 ` Jeff Garzik [this message]
2003-08-11 17:04 ` Larry McVoy
2003-08-11 17:15 ` Jeff Garzik
2003-08-11 17:23 ` Larry McVoy
2003-08-11 17:53 ` Jeff Garzik
2003-08-11 17:59 ` Larry McVoy
2003-08-11 18:11 ` Jeff Garzik
2003-08-11 19:09 ` [Dri-devel] " Philip Brown
2003-08-12 12:07 ` Peter "Firefly" Lund
2003-08-12 10:00 ` Werner Almesberger
2003-08-13 19:44 ` Jamie Lokier
2003-08-14 14:21 ` Eli Carter
2003-08-14 14:47 ` Larry McVoy
2003-08-14 15:18 ` Eli Carter
2003-08-14 15:28 ` Larry McVoy
2003-08-14 19:01 ` Gene Heskett
2003-08-14 18:43 ` [Dri-devel] " Philip Brown
2003-08-14 18:59 ` Randy.Dunlap
2003-08-14 20:16 ` Larry McVoy
2003-08-14 20:21 ` Eli Carter
2003-08-14 20:22 ` Larry McVoy
[not found] <jnSd.6CM.1@gated-at.bofh.it>
[not found] ` <jo20.6MB.31@gated-at.bofh.it>
[not found] ` <jouY.7jw.9@gated-at.bofh.it>
[not found] ` <jov3.7jw.37@gated-at.bofh.it>
[not found] ` <joEI.7s9.9@gated-at.bofh.it>
[not found] ` <joOj.7Aj.11@gated-at.bofh.it>
[not found] ` <jphi.85s.1@gated-at.bofh.it>
[not found] ` <jphn.85s.17@gated-at.bofh.it>
2003-08-12 9:52 ` Ed Cogburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F37CB44.5000307@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm@bitmover.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).