From: Jeff Garzik <jgarzik@pobox.com>
To: Larry McVoy <lm@bitmover.com>
Cc: davej@redhat.com, torvalds@osdl.org,
linux-kernel@vger.kernel.org, dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] CodingStyle fixes for drm_agpsupport
Date: Mon, 11 Aug 2003 14:11:36 -0400 [thread overview]
Message-ID: <3F37DC58.503@pobox.com> (raw)
In-Reply-To: <20030811175941.GB4879@work.bitmover.com>
Larry McVoy wrote:
> On Mon, Aug 11, 2003 at 01:53:17PM -0400, Jeff Garzik wrote:
>
>>Larry McVoy wrote:
>>are function calls at a 10-nanosecond glance. Also, having two styles
>>of 'if' formatting in your example just screams "inconsistent" to me :)
>
>
> It is inconsistent, on purpose. It's essentially like perl's
>
> return unless pointer;
>
> which is a oneliner, almost like an assert().
perl is a yucky language full of hacks like this... one of the reasons
why I love it :)
So while perl's syntax sugar allows my hands to type a bit less, I'll
often find myself following a C style and doing
return
unless statement;
In general, I will continue to say the 'if' test should be completely
separately from the statement, no matter how short either are.
> Maybe this will help: I insist on braces on anything with indentation so
> that I can scan them more quickly. If I gave you a choice between
>
> if (!pointer) {
> return (whatever);
> }
>
> if (!pointer) return (whatever);
>
> which one will you type more often? I actually don't care which you use,
> I prefer the shorter one because I don't measure my self worth in lines
> of code generated, I tend to favor lines of code deleted :) But either
> one is fine, I tend to use the first one if it has been a problem area
> and I'm likely to come back and shove in some debugging.
>
> Before you say "lose the braces" try reading more code and see how much faster
> it is if all indented stuff has braces. You whiz through it.
Unless you get more than one or two independent 'if' tests like that,
then all those braces for a one-line test eat up wasted screen real
estate, slowing down the person reading the code.
So, if you gave me the choice above, I would choose option C, neither :)
>>Absolutely not. I'm cooler, so my opinion counts more.
>
>
> You are in North Carolina, I'm in San Francisco. No competition, you are
> sweating like a pig :)
>
>
>>>Same for your eyes when you get to my age.
>>
>>I bet when you were in school, you had to chip your homework into slate,
>>and dinner was brontosaurus-kebob, right?
>
>
> Dinner? You got dinner? Damn, you were spoiled.
hehe :)
Jeff
next prev parent reply other threads:[~2003-08-11 18:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 15:59 [PATCH] CodingStyle fixes for drm_agpsupport davej
2003-08-11 16:40 ` Larry McVoy
2003-08-11 16:58 ` Jeff Garzik
2003-08-11 17:04 ` Larry McVoy
2003-08-11 17:15 ` Jeff Garzik
2003-08-11 17:23 ` Larry McVoy
2003-08-11 17:53 ` Jeff Garzik
2003-08-11 17:59 ` Larry McVoy
2003-08-11 18:11 ` Jeff Garzik [this message]
2003-08-11 19:09 ` [Dri-devel] " Philip Brown
2003-08-12 12:07 ` Peter "Firefly" Lund
2003-08-12 10:00 ` Werner Almesberger
2003-08-13 19:44 ` Jamie Lokier
2003-08-14 14:21 ` Eli Carter
2003-08-14 14:47 ` Larry McVoy
2003-08-14 15:18 ` Eli Carter
2003-08-14 15:28 ` Larry McVoy
2003-08-14 19:01 ` Gene Heskett
2003-08-14 18:43 ` [Dri-devel] " Philip Brown
2003-08-14 18:59 ` Randy.Dunlap
2003-08-14 20:16 ` Larry McVoy
2003-08-14 20:21 ` Eli Carter
2003-08-14 20:22 ` Larry McVoy
[not found] <jnSd.6CM.1@gated-at.bofh.it>
[not found] ` <jo20.6MB.31@gated-at.bofh.it>
[not found] ` <jouY.7jw.9@gated-at.bofh.it>
[not found] ` <jov3.7jw.37@gated-at.bofh.it>
[not found] ` <joEI.7s9.9@gated-at.bofh.it>
[not found] ` <joOj.7Aj.11@gated-at.bofh.it>
[not found] ` <jphi.85s.1@gated-at.bofh.it>
[not found] ` <jphn.85s.17@gated-at.bofh.it>
2003-08-12 9:52 ` Ed Cogburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F37DC58.503@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lm@bitmover.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).