RE: make distclean and make dep??

RE: make distclean and make dep??

[Dan Steele]

>When I do a "make distclean" in a tree, should not that roll it back to a 
>clean empty tree? I noticed that when I did that no work was done by "make 
>dep" in the rebuild.
>Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
>"make help." It's really useful to have distclean work to build patched 
>kernels for distribution, hopefully this is an oversight and not a new 
>policy.
I've also noticed make rpm fails to link some stuff and craps out, around

arch/i386/kernel/built-in.o: In function `fix_broken_hp_bios_irq9':

which is odd because a make bzImage links it fine...

Dan.

Re: make distclean and make dep??

[Sam Ravnborg]

On Mon, Nov 18, 2002 at 10:36:20AM -0600, Kai Germaschewski wrote:
> But when do you need the "clean + rm .config*" behavior? I don't see that 
> to be such a common case.
> 
> That's why I think two targets are enough, "clean" to remove the files
> generated during the build and "distclean" to remove all other extra stuff
> to. And just keep mrproper to be an alias for distclean, since that's what
> "mrproper" traditionally was (AFAIK, Linus used it that way).

People are used to a mrproper that does NOT delete their editor
backup files and patch rejects. Thats the only arguments against
mrproper=distclean.

The main purpose should be to have a clear and logical
distingush between the two/three.
As it is today people are confused, and there is no consistency - 
especially between architectures.

I'm fine with a change that moves MRPROPER_{DIRS,FILES} to clean - except
.config.
But I'm not fine with the current situation where I have to say goodbye
to all my .rej files + xx~ files just to force a full recompile.

I will do a new patch tomorrow.

	Sam

Re: make distclean and make dep??

[Bill Davidsen]

On Mon, 18 Nov 2002, Kai Germaschewski wrote:

> On Sun, 17 Nov 2002, Bill Davidsen wrote:
> 
> > On Fri, 15 Nov 2002, Sam Ravnborg wrote:
> > 
> > > Here is first try:
> > > - clean now deletes all generated files except .config + .config.old
> > > - mrproper in addition to clean only deleted .config + .config.old
> > > - distclean in addition ot mrproper deletes backupfiles as usual.
> > 
> > Just what I wanted. If you can be happy doing this it now provides all
> > three useful behaviours in a clear manner.
> 
> But when do you need the "clean + rm .config*" behavior? I don't see that 
> to be such a common case.
> 
> That's why I think two targets are enough, "clean" to remove the files
> generated during the build and "distclean" to remove all other extra stuff
> to. And just keep mrproper to be an alias for distclean, since that's what
> "mrproper" traditionally was (AFAIK, Linus used it that way).

Let me note how I use the three levels of cleaning, and perhaps that will
clarify why I find them desirable.

1 - make clean
  When I apply a patch or make a config change, being paranoid I always
end the testing with a clean make and install.

2 - make mrproper
  When something works on the test machine, I will want to build it in
several other configurations to be tested on "non-critical production"
machines. These are machines actually used in normal work, although they
might be someone's personal work machine, a syslog server, a backup
{whatever} server, or similar. Test machines can afford to lose their
files, 2nd test could lose files but run kernels which have no lost files
or been reported to do so. A failure during hours when someone is
available to push the reset button is acceptable. I really don't want to
part with my original files or build logs at this point.

3 - make distclean
  When I'm about to create a whole "as built" kernel source to keep at
each site running that kernel, this is the one which should be absolutely
clean.

  The way I use it item 2 is the easiest to do by hand, but since people
have been using it *in just that way* up to 2.5.45 or so, why change?
Historically many other packages have used distclean as the cleanest
target, many Linux packages have it, and it's a defacto standard.

  Again, why change something which has been around for years and has had
no problems, complaints, or maintenence. All three are useful and have
been around for a long time, and might be in test scripts for all I
know.

  Sam seems to have agreed that this is useful, unless there's a good
reason not to leave these as historically they have been and as he has
proposed to return them, that should end it. If you have seen some problem
caused by this do describe.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Kai Germaschewski]

On Sun, 17 Nov 2002, Bill Davidsen wrote:

> On Fri, 15 Nov 2002, Sam Ravnborg wrote:
> 
> > Here is first try:
> > - clean now deletes all generated files except .config + .config.old
> > - mrproper in addition to clean only deleted .config + .config.old
> > - distclean in addition ot mrproper deletes backupfiles as usual.
> 
> Just what I wanted. If you can be happy doing this it now provides all
> three useful behaviours in a clear manner.

But when do you need the "clean + rm .config*" behavior? I don't see that 
to be such a common case.

That's why I think two targets are enough, "clean" to remove the files
generated during the build and "distclean" to remove all other extra stuff
to. And just keep mrproper to be an alias for distclean, since that's what
"mrproper" traditionally was (AFAIK, Linus used it that way).

--Kai

Re: make distclean and make dep??

[Bill Davidsen]

On Fri, 15 Nov 2002, Sam Ravnborg wrote:

> Here is first try:
> - clean now deletes all generated files except .config + .config.old
> - mrproper in addition to clean only deleted .config + .config.old
> - distclean in addition ot mrproper deletes backupfiles as usual.

Just what I wanted. If you can be happy doing this it now provides all
three useful behaviours in a clear manner.

Good show!

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Sam Ravnborg]

On Fri, Nov 15, 2002 at 02:29:54PM -0500, Bill Davidsen wrote:
> > I have explained how I would like it to work - any comments on that proposal?
> 
>   Same comment, I want (a) something which will remake everything
> including *versions.h to be sure I didn't mess anything up, and (b) as a
> but removed the editor and patch backup files ready for distribution. I
> don't want to lose the patch backup files (I care less about editor files,
> my chosen editor doesn't make them) but I want to be able to easily
> identify what has changed without keeping a full unmodified copy of the
> tree.
Here is first try:
- clean now deletes all generated files except .config + .config.old
- mrproper in addition to clean only deleted .config + .config.old
- distclean in addition ot mrproper deletes backupfiles as usual.

It does not break architectures but they are also affected by the fact that
clean has taken over the job from mrproper.
So archclean and archmrproper has become the same.

I have not changed what is deleted, the difference is that I have moved
even more to the clean stage.

Try with 
$make KBUILD_VERBOSE=0 distclean
and let me know if more info is required in the condensed format.

	Sam

===== Makefile 1.346 vs edited =====
--- 1.346/Makefile	Sat Nov  9 05:08:32 2002
+++ edited/Makefile	Fri Nov 15 22:15:29 2002
@@ -662,20 +662,17 @@
 # make distclean Remove editor backup files, patch leftover files and the like
 
 # Files removed with 'make clean'
-CLEAN_FILES += vmlinux System.map MC*
-
-# Files removed with 'make mrproper'
-MRPROPER_FILES += \
+CLEAN_FILES += vmlinux System.map MC* \
 	include/linux/autoconf.h include/linux/version.h \
 	.version .config .config.old config.in config.old \
 	.menuconfig.log \
 	include/asm \
 	.hdepend include/linux/modversions.h \
 	tags TAGS kernel.spec \
-	.tmp*
+	.tmp* $(MRPROPER_FILES)
 
 # Directories removed with 'make mrproper'
-MRPROPER_DIRS += \
+CLEAN_DIRS += $(MRPROPER_DIRS) \
 	.tmp_export-objs \
 	include/config \
 	include/linux/modules
@@ -687,27 +684,37 @@
 $(addprefix _clean_,$(clean-dirs)):
 	$(Q)$(MAKE) -f scripts/Makefile.clean obj=$(patsubst _clean_%,%,$@)
 
-quiet_cmd_rmclean = RM  $$(CLEAN_FILES)
-cmd_rmclean	  = rm -f $(CLEAN_FILES)
-clean: archclean $(addprefix _clean_,$(clean-dirs))
-	$(call cmd,rmclean)
-	@find . $(RCS_FIND_IGNORE) \
+quiet_cmd_rmclean  = CLEAN   $$(CLEAN_FILES)
+      cmd_rmclean  = rm -f    $(CLEAN_FILES)
+quiet_cmd_rmdclean = CLEAN   $$(CLEAN_DIRS)
+      cmd_rmdclean = rm -rf   $(CLEAN_DIRS)
+quiet_cmd_rmsclean = CLEAN   *.[oas] in the srctree
+      cmd_rmsclean = find . $(RCS_FIND_IGNORE) \
 	 	\( -name '*.[oas]' -o -name '.*.cmd' -o -name '.*.d' \
 		-o -name '.*.tmp' \) -type f -print | xargs rm -f
 
-# mrproper - delete configuration + modules + core files
+clean: archclean archmrproper $(addprefix _clean_,$(clean-dirs))
+	$(call cmd,rmclean)
+	$(call cmd,rmdclean)
+	$(call cmd,rmsclean)
+
+# mrproper - 'make clean' + delete configuration
 #
-quiet_cmd_mrproper = RM  $$(MRPROPER_DIRS) + $$(MRPROPER_FILES)
-cmd_mrproper = rm -rf $(MRPROPER_DIRS) && rm -f $(MRPROPER_FILES)
-mrproper distclean: clean archmrproper
-	@echo '  Making $@ in the srctree'
-	@find . $(RCS_FIND_IGNORE) \
+quiet_cmd_mrproper = RM      .config .config.old
+      cmd_mrproper = rm -rf .config .config.old
+mrproper: clean archmrproper
+	$(call cmd,mrproper)
+
+quiet_cmd_distclean = DISTCLEAN
+      cmd_distclean = find . $(RCS_FIND_IGNORE) \
 	 	\( -name '*.orig' -o -name '*.rej' -o -name '*~' \
-		-o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \
+		-o -name '*.bak' -o -name '\#*\#' -o -name '.*.orig' \
 	 	-o -name '.*.rej' -o -size 0 \
 		-o -name '*%' -o -name '.*.cmd' -o -name 'core' \) \
 		-type f -print | xargs rm -f
-	$(call cmd,mrproper)
+
+distclean: mrproper
+	$(call cmd,distclean)
 
 # Generate tags for editors
 # ---------------------------------------------------------------------------
@@ -750,8 +757,9 @@
 
 help:
 	@echo  'Cleaning targets:'
-	@echo  '  clean		- remove most generated files but keep the config'
-	@echo  '  mrproper	- remove all generated files + config + various backup files'
+	@echo  '  clean		- remove all generated files but keep the config'
+	@echo  '  mrproper	- clean + configuration is removed'
+	@echo  '  distclean     - mrproper + all editor and patch leftovers removed'
 	@echo  ''
 	@echo  'Configuration targets:'
 	@echo  '  oldconfig	- Update current config utilising a line-oriented program'

Re: make distclean and make dep??

[Bill Davidsen]

On Fri, 15 Nov 2002, Sam Ravnborg wrote:

> On Thu, Nov 14, 2002 at 07:31:24PM -0500, Bill Davidsen wrote:

> > I don't see why you ever thought it was a good idea to change this,
> > distclean is that standard target used by many other things. And perhaps
> > mrproper shouldn't bother to clean up all the leftovers, patch backups,
> > they are documentation.
> I have explained how I would like it to work - any comments on that proposal?

  Same comment, I want (a) something which will remake everything
including *versions.h to be sure I didn't mess anything up, and (b) as a
but removed the editor and patch backup files ready for distribution. I
don't want to lose the patch backup files (I care less about editor files,
my chosen editor doesn't make them) but I want to be able to easily
identify what has changed without keeping a full unmodified copy of the
tree.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Sam Ravnborg]

On Fri, Nov 15, 2002 at 11:01:05AM -0500, Nicolas Pitre wrote:
> On Fri, 15 Nov 2002, Sam Ravnborg wrote:
> 
> > On Thu, Nov 14, 2002 at 07:31:24PM -0500, Bill Davidsen wrote:
> > > > No need for that, when make clean deletes enough.
> > > 
> > > Unless you want to make a distribution, or see that a distribution made
> > > from your patched kernel would build.
> > Then let me repeat again:
> > distclean and mrproper is combined today. They do exactly the same.
> 
> In this case distclean should return in the target help text then.
It will.

	Sam

Re: make distclean and make dep??

[Nicolas Pitre]

On Fri, 15 Nov 2002, Sam Ravnborg wrote:

> On Thu, Nov 14, 2002 at 07:31:24PM -0500, Bill Davidsen wrote:
> > > No need for that, when make clean deletes enough.
> > 
> > Unless you want to make a distribution, or see that a distribution made
> > from your patched kernel would build.
> Then let me repeat again:
> distclean and mrproper is combined today. They do exactly the same.

In this case distclean should return in the target help text then.


Nicolas

Re: make distclean and make dep??

[Sam Ravnborg]

On Thu, Nov 14, 2002 at 07:31:24PM -0500, Bill Davidsen wrote:
> > No need for that, when make clean deletes enough.
> 
> Unless you want to make a distribution, or see that a distribution made
> from your patched kernel would build.
Then let me repeat again:
distclean and mrproper is combined today. They do exactly the same.
So what was deleted by make distclean in 2.40 is still deleted by
make distclean in 2.5.47.
What has happened is that mrproper and distclean now deletes the sum of files
they delted before.

> > Only caveat is that people are forced to wait for the modversion stuff,
> 
> I get "nothing to be done" for make dep after make distclean.
Which is unrelated. Thats due to the module work that Rusty is performing.
Relevant part of his patch: (from linus-BK-latest)

===== init/Kconfig 1.1 vs 1.2 =====
--- 1.1/init/Kconfig	Wed Oct 30 02:16:55 2002
+++ 1.2/init/Kconfig	Sat Nov  9 05:08:33 2002
@@ -116,21 +116,14 @@
 	  may want to make use of modules with this kernel in the future, then
 	  say Y here.  If unsure, say Y.
 
-config MODVERSIONS
-	bool "Set version information on all module symbols"



See, modversion support is taken out.
And when you try make dep, you get "nothing to be done" because
CONFIG_MODVERSION is not set to y.
If it was set in your previous .config, then the implicit make oldconfig
takes care of deleting it.

Try:
$grep MODVERSION .config
and see yourself.

> > but to my understanding Rusty is making that step obsolete soon.
> 
> I hope he isn't wasting his time on stuff like this when modules don't
> work! I have more faith in his sense of priorities.
Getting modules to work is one step in that direction, and making
modversion obsolete is obviously a side-effect.

> Possibly. Try this:
> 1 - unpack a kernel from the full tarball
> 2 - config
> 3 - make all
> 4 - make distclean
> Now all the files left which weren't in the original tarball shouldn't be
> in a tree someone might tar up and ship! Look at what make distclean used
> to do beyond mrproper in 2.5.41 or so, that's what should be happening.
Let me know which files are left, and I will take care they are delted.
I have tested this many times on my own setup, and here I have no files
left hanging after make distclean/mrproper
If there are any error, I will be happy to fix it.

> I don't see why you ever thought it was a good idea to change this,
> distclean is that standard target used by many other things. And perhaps
> mrproper shouldn't bother to clean up all the leftovers, patch backups,
> they are documentation.
I have explained how I would like it to work - any comments on that proposal?

Anyway this kind of changes always go throuh kai - and he is busy doing
other stuff at the moment. So I will do an eventual patch later.

	Sam

Re: make distclean and make dep??

[Bill Davidsen]

On Thu, 14 Nov 2002, Sam Ravnborg wrote:

> In other words a more powerfull clean compared to today.
> The difference between clean and mrproper is then _only_ the configuration
> files. That easy to explain, and thats easy to understand. Today only
> very few people know the difference, and simply save their config,
> and do make mrproper.
> 
> I have many times seen people do something like:
> cp .config xxx
> make mrproper
> mv xxx .config
> 
> No need for that, when make clean deletes enough.

Unless you want to make a distribution, or see that a distribution made
from your patched kernel would build.
 
> Only caveat is that people are forced to wait for the modversion stuff,

I get "nothing to be done" for make dep after make distclean.

> but to my understanding Rusty is making that step obsolete soon.

I hope he isn't wasting his time on stuff like this when modules don't
work! I have more faith in his sense of priorities.

> Did I miss something obvious?

Possibly. Try this:
1 - unpack a kernel from the full tarball
2 - config
3 - make all
4 - make distclean
Now all the files left which weren't in the original tarball shouldn't be
in a tree someone might tar up and ship! Look at what make distclean used
to do beyond mrproper in 2.5.41 or so, that's what should be happening.

I don't see why you ever thought it was a good idea to change this,
distclean is that standard target used by many other things. And perhaps
mrproper shouldn't bother to clean up all the leftovers, patch backups,
they are documentation.

I believe you went into this not understanding the difference and why
there was one, and now you are defending how good it is not to have a way
to get a clean tree other than write a script which does what distclean
used to do. And the solution is not to have mrproper delete the original
files, they are useful!

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Mark Hounschell]

Sam Ravnborg wrote:
> 
> On Thu, Nov 14, 2002 at 09:35:53AM -0600, Kai Germaschewski wrote:
> > I think there's good reasons for both distclean and mrproper, distclean is
> > the standard target which most projects use, and mrproper is the
> > traditional Linux kernel target. So I would vote for keeping them both
> > (and share a common help entry).
> >
> > What I don't see is why we would need different semantics, though,
> > anybody?
> How about the following:
> clean   Delete all intermidiate files, including symlinks and modversions
> mrproper        clean + deletes .config and .config.old
> distclean       mrproper + all editor backup, patch backup files
> 
> In other words a more powerfull clean compared to today.
> The difference between clean and mrproper is then _only_ the configuration
> files. That easy to explain, and thats easy to understand. Today only
> very few people know the difference, and simply save their config,
> and do make mrproper.
> 
> I have many times seen people do something like:
> cp .config xxx
> make mrproper
> mv xxx .config
> 
> No need for that, when make clean deletes enough.

I thought make mrproper cleaned whatever make dep did also. Make clean certainly
does not.
I never need a make dep after a clean. Only after a make mrproper???

Mark

Re: make distclean and make dep??

[Nicolas Pitre]

On Thu, 14 Nov 2002, Sam Ravnborg wrote:

> On Thu, Nov 14, 2002 at 09:35:53AM -0600, Kai Germaschewski wrote:
> > I think there's good reasons for both distclean and mrproper, distclean is
> > the standard target which most projects use, and mrproper is the
> > traditional Linux kernel target. So I would vote for keeping them both
> > (and share a common help entry).
> > 
> > What I don't see is why we would need different semantics, though, 
> > anybody?
> How about the following:
> clean	Delete all intermidiate files, including symlinks and modversions
> mrproper	clean + deletes .config and .config.old
> distclean	mrproper + all editor backup, patch backup files

Looks sensible to me.


Nicolas

Re: make distclean and make dep??

[Sam Ravnborg]

On Thu, Nov 14, 2002 at 09:35:53AM -0600, Kai Germaschewski wrote:
> I think there's good reasons for both distclean and mrproper, distclean is
> the standard target which most projects use, and mrproper is the
> traditional Linux kernel target. So I would vote for keeping them both
> (and share a common help entry).
> 
> What I don't see is why we would need different semantics, though, 
> anybody?
How about the following:
clean	Delete all intermidiate files, including symlinks and modversions
mrproper	clean + deletes .config and .config.old
distclean	mrproper + all editor backup, patch backup files

In other words a more powerfull clean compared to today.
The difference between clean and mrproper is then _only_ the configuration
files. That easy to explain, and thats easy to understand. Today only
very few people know the difference, and simply save their config,
and do make mrproper.

I have many times seen people do something like:
cp .config xxx
make mrproper
mv xxx .config

No need for that, when make clean deletes enough.

Only caveat is that people are forced to wait for the modversion stuff,
but to my understanding Rusty is making that step obsolete soon.
Did I miss something obvious?

	Sam

Re: make distclean and make dep??

[Sam Ravnborg]

On Wed, Nov 13, 2002 at 06:09:02PM -0500, Bill Davidsen wrote:
> > So mrproper and distclean behave in the same way.
> 
> So neither of them actually cleans the source tree to release a
> distribution anymore?
distclean aka mrproper these days cleans as much as it used to.
Let me know if you encounter something it fails to clean up, and I will
see to that it is fixed.

	Sam

Re: make distclean and make dep??

[Kai Germaschewski]

On Wed, 13 Nov 2002, Nicolas Pitre wrote:

> On Wed, 13 Nov 2002, Andreas Steinmetz wrote:
> 
> > Sam Ravnborg wrote:
> > > On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
> > >>Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
> > >>"make help." It's really useful to have distclean work to build patched 
> > >>kernels for distribution, hopefully this is an oversight and not a new 
> > >>policy.
> > > 
> > > Since they are equal I removed the help for the less used version.
> > 
> > Not so nice. /me e.g. is used to distclean, never used mrproper and 
> > distclean is a standard target in most projects, so people are probably 
> > more used to distclean than mrproper which is kernel specific.

I think there's good reasons for both distclean and mrproper, distclean is
the standard target which most projects use, and mrproper is the
traditional Linux kernel target. So I would vote for keeping them both
(and share a common help entry).

What I don't see is why we would need different semantics, though, 
anybody?

--Kai

Re: make distclean and make dep??

[Bill Davidsen]

On Wed, 13 Nov 2002, Andreas Steinmetz wrote:

> Sam Ravnborg wrote:
> > On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
> >>Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
> >>"make help." It's really useful to have distclean work to build patched 
> >>kernels for distribution, hopefully this is an oversight and not a new 
> >>policy.
> > 
> > Since they are equal I removed the help for the less used version.
> 
> Not so nice. /me e.g. is used to distclean, never used mrproper and 
> distclean is a standard target in most projects, so people are probably 
> more used to distclean than mrproper which is kernel specific.
> The thing to point this out is that if the help is removed the target 
> will presumably be removed sooner or later, too.
> 

Might as well, the distclean functionality is gone, neither does the full
cleanup.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Bill Davidsen]

On Wed, 13 Nov 2002, Sam Ravnborg wrote:

> On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
> > When I do a "make distclean" in a tree, should not that roll it back to a 
> > clean empty tree? I noticed that when I did that no work was done by "make 
> > dep" in the rebuild.
> With the recent module related changes CONFIG_MODVERSIONS has disappeared.
> Therefore make dep became a noop.
> 
> > Distclean is supposed to be even cleaner than mrproper (to build a clean
> > tree for distribution) and this behaviour is new.
> distclean and mrproper has been merged as of 2.44 IIRC.
> So mrproper and distclean behave in the same way.

So neither of them actually cleans the source tree to release a
distribution anymore? The difference between them was useful, distclean
got rid of version headers and some other assorted cruft you don't want in
a distribution.
 
> > Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
> > "make help." It's really useful to have distclean work to build patched 
> > kernels for distribution, hopefully this is an oversight and not a new 
> > policy.
> Since they are equal I removed the help for the less used version.

Thanks for the explanation, but I wonder if it was really worth having
people write their own clean scripts to avoid maintaining a few lines of
Makefile which haven't changed in ages.

-- 
bill davidsen <davidsen@tmr.com>
  CTO, TMR Associates, Inc
Doing interesting things with little computers since 1979.

Re: make distclean and make dep??

[Nicolas Pitre]

On Wed, 13 Nov 2002, Andreas Steinmetz wrote:

> Sam Ravnborg wrote:
> > On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
> >>Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
> >>"make help." It's really useful to have distclean work to build patched 
> >>kernels for distribution, hopefully this is an oversight and not a new 
> >>policy.
> > 
> > Since they are equal I removed the help for the less used version.
> 
> Not so nice. /me e.g. is used to distclean, never used mrproper and 
> distclean is a standard target in most projects, so people are probably 
> more used to distclean than mrproper which is kernel specific.

I agree with this.

If one of them must go then it should be mrproper.


Nicolas

Re: make distclean and make dep??

[Andreas Steinmetz]

Sam Ravnborg wrote:
> On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
>>Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
>>"make help." It's really useful to have distclean work to build patched 
>>kernels for distribution, hopefully this is an oversight and not a new 
>>policy.
> 
> Since they are equal I removed the help for the less used version.

Not so nice. /me e.g. is used to distclean, never used mrproper and 
distclean is a standard target in most projects, so people are probably 
more used to distclean than mrproper which is kernel specific.
The thing to point this out is that if the help is removed the target 
will presumably be removed sooner or later, too.

Re: make distclean and make dep??

[Sam Ravnborg]

On Wed, Nov 13, 2002 at 02:32:27PM -0500, Bill Davidsen wrote:
> When I do a "make distclean" in a tree, should not that roll it back to a 
> clean empty tree? I noticed that when I did that no work was done by "make 
> dep" in the rebuild.
With the recent module related changes CONFIG_MODVERSIONS has disappeared.
Therefore make dep became a noop.

> Distclean is supposed to be even cleaner than mrproper (to build a clean
> tree for distribution) and this behaviour is new.
distclean and mrproper has been merged as of 2.44 IIRC.
So mrproper and distclean behave in the same way.

> Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
> "make help." It's really useful to have distclean work to build patched 
> kernels for distribution, hopefully this is an oversight and not a new 
> policy.
Since they are equal I removed the help for the less used version.

	Sam

make distclean and make dep??

[Bill Davidsen]

When I do a "make distclean" in a tree, should not that roll it back to a 
clean empty tree? I noticed that when I did that no work was done by "make 
dep" in the rebuild.

Distclean is supposed to be even cleaner than mrproper (to build a clean
tree for distribution) and this behaviour is new.

Also noted, somewhere between 2.5.45 and 2.5.46 distclean vanished from 
"make help." It's really useful to have distclean work to build patched 
kernels for distribution, hopefully this is an oversight and not a new 
policy.

Obviously I can delete modversions.h by hand.

--
bill davidsen <davidsen@tmr.com>