From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org, marijn.suijten@somainline.org,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for MMU500 adreno SMMUs
Date: Mon, 27 Feb 2023 09:43:15 +0100 [thread overview]
Message-ID: <3aa78b15-8e6c-9657-0d08-0d0452d51fbe@linaro.org> (raw)
In-Reply-To: <20230226173706.GA60188-robh@kernel.org>
On 26.02.2023 18:37, Rob Herring wrote:
> On Fri, Feb 17, 2023 at 12:16:08PM +0100, Konrad Dybcio wrote:
>> qcom,smmu-500 was introduced to prevent people from adding new
>> compatibles for what seems to roughly be the same hardware. Use it for
>> qcom,adreno-smmu-compatible targets as well.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> v1 -> v2:
>> - Add this patch, omitted previously (big oops)
>>
>> .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++++--
>> 1 file changed, 12 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 807cb511fe18..4d7f61700cae 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -75,9 +75,19 @@ properties:
>> - qcom,sm8350-smmu-500
>> - qcom,sm8450-smmu-500
>> - const: arm,mmu-500
>> -
>> - - description: Qcom Adreno GPUs implementing "arm,smmu-500"
>> + - description: Qcom Adreno GPUs implementing "qcom,smmu-500" and "arm,smmu-500"
>> + items:
>> + - enum:
>> + - qcom,sc7280-smmu-500
>> + - qcom,sm8150-smmu-500
>> + - qcom,sm8250-smmu-500
>> + - const: qcom,adreno-smmu
>> + - const: qcom,smmu-500
>> + - const: arm,mmu-500
>
> 4 compatibles seems excessive. Is adding one that helpful? Is
> 'arm,mmu-500' useful on its own?
Yes.
per-soc compatible is there for per-soc quirks should there be any
qcom,adreno-smmu enabled per-process pagetables
qcom,smmu-500 matches the qcom smmu implementation
arm,mmu-500 matches the smmu driver as a whole
>
>> + - description: Qcom Adreno GPUs implementing "arm,smmu-500" (legacy binding)
>
> Perhaps fix the existing typo: arm,mmu-500
Ack
Konrad
>
>> + deprecated: true
>> items:
>> + # Do not add additional SoC to this list. Instead use previous list.
>> - enum:
>> - qcom,sc7280-smmu-500
>> - qcom,sm8150-smmu-500
>> --
>> 2.39.1
>>
next prev parent reply other threads:[~2023-02-27 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 11:16 [PATCH v2 1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for MMU500 adreno SMMUs Konrad Dybcio
2023-02-17 11:16 ` [PATCH v2 2/6] dt-bindings: arm-smmu: Add SM8350 Adreno SMMU Konrad Dybcio
2023-02-27 8:13 ` Krzysztof Kozlowski
2023-02-17 11:16 ` [PATCH v2 3/6] arm64: dts: qcom: sc7280: Add qcom,smmu-500 to " Konrad Dybcio
2023-02-17 11:16 ` [PATCH v2 4/6] arm64: dts: qcom: sm8150: " Konrad Dybcio
2023-02-17 11:16 ` [PATCH v2 5/6] arm64: dts: qcom: sm8250: " Konrad Dybcio
2023-02-17 11:16 ` [PATCH v2 6/6] arm64: dts: qcom: sm8350: " Konrad Dybcio
2023-02-26 17:37 ` [PATCH v2 1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for MMU500 adreno SMMUs Rob Herring
2023-02-27 8:43 ` Konrad Dybcio [this message]
2023-02-27 8:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa78b15-8e6c-9657-0d08-0d0452d51fbe@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).