* [PATCH -next] s390: cio: Use DEFINE_SPINLOCK() for spinlock
@ 2020-12-23 14:15 Zheng Yongjun
2021-01-07 17:27 ` Julian Wiedmann
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2020-12-23 14:15 UTC (permalink / raw)
To: linux-s390, linux-kernel; +Cc: Zheng Yongjun
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/s390/cio/css.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
index cca1a7c4bb33..022f573f0bcc 100644
--- a/drivers/s390/cio/css.c
+++ b/drivers/s390/cio/css.c
@@ -647,13 +647,12 @@ static void css_sch_todo(struct work_struct *work)
}
static struct idset *slow_subchannel_set;
-static spinlock_t slow_subchannel_lock;
+static DEFINE_SPINLOCK(slow_subchannel_lock);
static wait_queue_head_t css_eval_wq;
static atomic_t css_eval_scheduled;
static int __init slow_subchannel_init(void)
{
- spin_lock_init(&slow_subchannel_lock);
atomic_set(&css_eval_scheduled, 0);
init_waitqueue_head(&css_eval_wq);
slow_subchannel_set = idset_sch_new();
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] s390: cio: Use DEFINE_SPINLOCK() for spinlock
2020-12-23 14:15 [PATCH -next] s390: cio: Use DEFINE_SPINLOCK() for spinlock Zheng Yongjun
@ 2021-01-07 17:27 ` Julian Wiedmann
0 siblings, 0 replies; 2+ messages in thread
From: Julian Wiedmann @ 2021-01-07 17:27 UTC (permalink / raw)
To: Zheng Yongjun, linux-s390, linux-kernel
On 23.12.20 15:15, Zheng Yongjun wrote:
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/s390/cio/css.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
> index cca1a7c4bb33..022f573f0bcc 100644
> --- a/drivers/s390/cio/css.c
> +++ b/drivers/s390/cio/css.c
> @@ -647,13 +647,12 @@ static void css_sch_todo(struct work_struct *work)
> }
>
> static struct idset *slow_subchannel_set;
> -static spinlock_t slow_subchannel_lock;
> +static DEFINE_SPINLOCK(slow_subchannel_lock);
> static wait_queue_head_t css_eval_wq;
> static atomic_t css_eval_scheduled;
>
> static int __init slow_subchannel_init(void)
> {
> - spin_lock_init(&slow_subchannel_lock);
> atomic_set(&css_eval_scheduled, 0);
> init_waitqueue_head(&css_eval_wq);
Mind turning these two into static initializations as well? Thanks.
> slow_subchannel_set = idset_sch_new();
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-07 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23 14:15 [PATCH -next] s390: cio: Use DEFINE_SPINLOCK() for spinlock Zheng Yongjun
2021-01-07 17:27 ` Julian Wiedmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).