From: "Gong, Richard" <richard.gong@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lijo.lazar@amd.com, Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCHv1] ACPI: processor idle: Allow playing dead in C3 state
Date: Tue, 28 Sep 2021 08:00:52 -0500 [thread overview]
Message-ID: <3b26b179-69ba-64a2-807e-8d7609fbeb6e@amd.com> (raw)
In-Reply-To: <CAJZ5v0jpOzNS5TFdJNXdxa_p2D_5QQMwwRcSMe8JmjOaTjR8gg@mail.gmail.com>
Hi Rafael,
On 9/24/2021 11:31 AM, Rafael J. Wysocki wrote:
> On Wed, Sep 22, 2021 at 3:31 PM Richard Gong <richard.gong@amd.com> wrote:
>> When some cores are disabled on AMD platforms, the system will no longer
>> be able to enter suspend-to-idle s0ix.
>>
>> Update to allow playing dead in C3 state so that the CPUs can enter the
>> deepest state on AMD platforms.
>>
>> BugLink: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fdrm%2Famd%2F-%2Fissues%2F1708&data=04%7C01%7Crichard.gong%40amd.com%7Ca5c0db9ce02b4cd0864f08d97f78d33f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637680980065602427%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dIO5PDjpncLFIt0aGaTrKJHYIkJm8A4YByGn1%2FsHrtM%3D&reserved=0
>> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
>> Signed-off-by: Richard Gong <richard.gong@amd.com>
>> ---
>> drivers/acpi/processor_idle.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
>> index f37fba9e5ba0..61d5a72d218e 100644
>> --- a/drivers/acpi/processor_idle.c
>> +++ b/drivers/acpi/processor_idle.c
>> @@ -789,7 +789,8 @@ static int acpi_processor_setup_cstates(struct acpi_processor *pr)
>> state->enter = acpi_idle_enter;
>>
>> state->flags = 0;
>> - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2) {
>> + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2
>> + || cx->type == ACPI_STATE_C3) {
>> state->enter_dead = acpi_idle_play_dead;
>> drv->safe_state_index = count;
>> }
>> --
> Tentatively applied as 5.16 material, but have you done any research
> on why this restriction has been there in the first place?
Yes, we need this change to align with the updated firmware on AMD
platforms.
Regards,
Richard
next prev parent reply other threads:[~2021-09-28 13:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 13:31 [PATCHv1] ACPI: processor idle: Allow playing dead in C3 state Richard Gong
2021-09-24 16:31 ` Rafael J. Wysocki
2021-09-28 13:00 ` Gong, Richard [this message]
2021-09-28 13:48 ` Rafael J. Wysocki
2021-09-28 15:08 ` Lazar, Lijo
2021-09-29 5:37 ` Lazar, Lijo
2021-09-29 14:09 ` Boris Ostrovsky
2021-09-29 14:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b26b179-69ba-64a2-807e-8d7609fbeb6e@amd.com \
--to=richard.gong@amd.com \
--cc=lenb@kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).