From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Richard Gong <richard.gong@amd.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lijo.lazar@amd.com, Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCHv1] ACPI: processor idle: Allow playing dead in C3 state
Date: Fri, 24 Sep 2021 18:31:44 +0200 [thread overview]
Message-ID: <CAJZ5v0jpOzNS5TFdJNXdxa_p2D_5QQMwwRcSMe8JmjOaTjR8gg@mail.gmail.com> (raw)
In-Reply-To: <20210922133116.102-1-richard.gong@amd.com>
On Wed, Sep 22, 2021 at 3:31 PM Richard Gong <richard.gong@amd.com> wrote:
>
> When some cores are disabled on AMD platforms, the system will no longer
> be able to enter suspend-to-idle s0ix.
>
> Update to allow playing dead in C3 state so that the CPUs can enter the
> deepest state on AMD platforms.
>
> BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1708
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> Signed-off-by: Richard Gong <richard.gong@amd.com>
> ---
> drivers/acpi/processor_idle.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f37fba9e5ba0..61d5a72d218e 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -789,7 +789,8 @@ static int acpi_processor_setup_cstates(struct acpi_processor *pr)
> state->enter = acpi_idle_enter;
>
> state->flags = 0;
> - if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2) {
> + if (cx->type == ACPI_STATE_C1 || cx->type == ACPI_STATE_C2
> + || cx->type == ACPI_STATE_C3) {
> state->enter_dead = acpi_idle_play_dead;
> drv->safe_state_index = count;
> }
> --
Tentatively applied as 5.16 material, but have you done any research
on why this restriction has been there in the first place?
next prev parent reply other threads:[~2021-09-24 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 13:31 [PATCHv1] ACPI: processor idle: Allow playing dead in C3 state Richard Gong
2021-09-24 16:31 ` Rafael J. Wysocki [this message]
2021-09-28 13:00 ` Gong, Richard
2021-09-28 13:48 ` Rafael J. Wysocki
2021-09-28 15:08 ` Lazar, Lijo
2021-09-29 5:37 ` Lazar, Lijo
2021-09-29 14:09 ` Boris Ostrovsky
2021-09-29 14:45 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0jpOzNS5TFdJNXdxa_p2D_5QQMwwRcSMe8JmjOaTjR8gg@mail.gmail.com \
--to=rafael@kernel.org \
--cc=lenb@kernel.org \
--cc=lijo.lazar@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=richard.gong@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).