* [PATCH] iio: humidity: hdc100x: correct humidity integration time mask
@ 2016-05-20 17:06 Alison Schofield
2016-05-20 17:44 ` Matt Ranostay
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2016-05-20 17:06 UTC (permalink / raw)
To: jic23; +Cc: mranostay, knaack.h, lars, pmeerw, linux-iio, linux-kernel
Apply the correct mask to enable all available humidity integration
times. Currently, the driver defaults to 6500 and all is okay with that.
However, if 3850 is selected we get a stuck bit and can't change back
to 6500 or select 2500. (Verified with HDC1008)
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
drivers/iio/humidity/hdc100x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
index fa47676..59aa1cb 100644
--- a/drivers/iio/humidity/hdc100x.c
+++ b/drivers/iio/humidity/hdc100x.c
@@ -55,7 +55,7 @@ static const struct {
},
{ /* IIO_HUMIDITYRELATIVE channel */
.shift = 8,
- .mask = 2,
+ .mask = 3,
},
};
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask
2016-05-20 17:06 [PATCH] iio: humidity: hdc100x: correct humidity integration time mask Alison Schofield
@ 2016-05-20 17:44 ` Matt Ranostay
2016-05-21 16:23 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Matt Ranostay @ 2016-05-20 17:44 UTC (permalink / raw)
To: Alison Schofield
Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, linux-iio, linux-kernel
Reviewed-by: Matt Ranostay <mranostay@gmail.com>
On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@gmail.com> wrote:
> Apply the correct mask to enable all available humidity integration
> times. Currently, the driver defaults to 6500 and all is okay with that.
> However, if 3850 is selected we get a stuck bit and can't change back
> to 6500 or select 2500. (Verified with HDC1008)
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
> drivers/iio/humidity/hdc100x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index fa47676..59aa1cb 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -55,7 +55,7 @@ static const struct {
> },
> { /* IIO_HUMIDITYRELATIVE channel */
> .shift = 8,
> - .mask = 2,
> + .mask = 3,
Yikes that is embarrassing on my part! I guess our validation was only
in the high resolution mode... good catch!
> },
> };
>
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: humidity: hdc100x: correct humidity integration time mask
2016-05-20 17:44 ` Matt Ranostay
@ 2016-05-21 16:23 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2016-05-21 16:23 UTC (permalink / raw)
To: Matt Ranostay, Alison Schofield
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, linux-kernel
On 20/05/16 18:44, Matt Ranostay wrote:
> Reviewed-by: Matt Ranostay <mranostay@gmail.com>
>
> On Fri, May 20, 2016 at 10:06 AM, Alison Schofield <amsfield22@gmail.com> wrote:
>> Apply the correct mask to enable all available humidity integration
>> times. Currently, the driver defaults to 6500 and all is okay with that.
>> However, if 3850 is selected we get a stuck bit and can't change back
>> to 6500 or select 2500. (Verified with HDC1008)
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
Applied to the fixes-togreg-post-rc1 branch of iio.git
Thanks,
Jonathan
>> ---
>> drivers/iio/humidity/hdc100x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
>> index fa47676..59aa1cb 100644
>> --- a/drivers/iio/humidity/hdc100x.c
>> +++ b/drivers/iio/humidity/hdc100x.c
>> @@ -55,7 +55,7 @@ static const struct {
>> },
>> { /* IIO_HUMIDITYRELATIVE channel */
>> .shift = 8,
>> - .mask = 2,
>> + .mask = 3,
>
> Yikes that is embarrassing on my part! I guess our validation was only
> in the high resolution mode... good catch!
>
>> },
>> };
>>
>> --
>> 2.1.4
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-21 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-20 17:06 [PATCH] iio: humidity: hdc100x: correct humidity integration time mask Alison Schofield
2016-05-20 17:44 ` Matt Ranostay
2016-05-21 16:23 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).