linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Laurent Vivier <laurent@vivier.eu>, linux-kernel@vger.kernel.org
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-m68k@lists.linux-m68k.org,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	John Stultz <john.stultz@linaro.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH v16 4/4] m68k: introduce a virtual m68k machine
Date: Mon, 30 May 2022 18:14:28 -0700	[thread overview]
Message-ID: <3b783435-e734-5391-e758-d709e0462839@infradead.org> (raw)
In-Reply-To: <20220406201523.243733-5-laurent@vivier.eu>

Hi--

On 4/6/22 13:15, Laurent Vivier wrote:
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index eeab4f3e6c19..188a8f8a0104 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -149,6 +149,23 @@ config SUN3
>  
>  	  If you don't want to compile a kernel exclusively for a Sun 3, say N.
>  
> +config VIRT
> +	bool "Virtual M68k Machine support"
> +	depends on MMU
> +	select GENERIC_CLOCKEVENTS
> +	select GOLDFISH
> +	select GOLDFISH_TIMER
> +	select GOLDFISH_TTY
> +	select M68040
> +	select MMU_MOTOROLA if MMU
> +	select RTC_CLASS
> +	select RTC_DRV_GOLDFISH
> +	select TTY
> +	select VIRTIO_MMIO

This select VIRTIO_MMIO can cause a kconfig warning:

WARNING: unmet direct dependencies detected for VIRTIO_MMIO
  Depends on [n]: VIRTIO_MENU [=n] && HAS_IOMEM [=y] && HAS_DMA [=y]
  Selected by [y]:
  - VIRT [=y] && M68KCLASSIC [=y] && MMU [=y]


> +	help
> +	  This options enable a pure virtual machine based on m68k,
> +	  VIRTIO MMIO devices and GOLDFISH interfaces (TTY, RTC, PIC)

The sentence above needs an ending period ('.').

> +
>  config PILOT
>  	bool

-- 
~Randy

  reply	other threads:[~2022-05-31  1:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 20:15 [PATCH v16 0/4] m68k: Add Virtual M68k Machine Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 1/4] tty: goldfish: introduce gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-04-07  4:48   ` Greg KH
2022-04-07  6:00     ` Laurent Vivier
2022-04-07  6:18       ` Greg KH
2022-04-11  8:53         ` Geert Uytterhoeven
2022-04-11  9:16           ` Greg KH
2022-04-06 20:15 ` [PATCH v16 2/4] rtc: goldfish: use gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 3/4] clocksource/drivers: Add a goldfish-timer clocksource Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 4/4] m68k: introduce a virtual m68k machine Laurent Vivier
2022-05-31  1:14   ` Randy Dunlap [this message]
2022-05-31  6:05     ` Laurent Vivier
2022-05-31  6:20       ` Arnd Bergmann
2022-05-31 16:32       ` Randy Dunlap
2022-04-11  9:55 ` [PATCH v16 0/4] m68k: Add Virtual M68k Machine Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b783435-e734-5391-e758-d709e0462839@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=daniel.lezcano@linaro.org \
    --cc=geert@linux-m68k.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=john.stultz@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).