From: Greg KH <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Vivier <laurent@vivier.eu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
John Stultz <john.stultz@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v16 1/4] tty: goldfish: introduce gf_ioread32()/gf_iowrite32()
Date: Mon, 11 Apr 2022 11:16:03 +0200 [thread overview]
Message-ID: <YlPx0/u/g9dMYxEn@kroah.com> (raw)
In-Reply-To: <CAMuHMdW=-nnKSLRZbHGkQQ8zEBxjQ4T1XXyTfv5-fM-h-+fQQA@mail.gmail.com>
On Mon, Apr 11, 2022 at 10:53:39AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Thu, Apr 7, 2022 at 8:18 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Thu, Apr 07, 2022 at 08:00:08AM +0200, Laurent Vivier wrote:
> > > Le 07/04/2022 à 06:48, Greg KH a écrit :
> > > > On Wed, Apr 06, 2022 at 10:15:20PM +0200, Laurent Vivier wrote:
> > > > > Revert
> > > > > commit da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
> > > > >
> > > > > and define gf_ioread32()/gf_iowrite32() to be able to use accessors
> > > > > defined by the architecture.
> > > > >
> > > > > Cc: stable@vger.kernel.org # v5.11+
> > > > > Fixes: da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
> > > > > Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> > > > > Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > > ---
> > > > > drivers/tty/goldfish.c | 20 ++++++++++----------
> > > > > include/linux/goldfish.h | 15 +++++++++++----
> > > > > 2 files changed, 21 insertions(+), 14 deletions(-)
> > > > >
> > > >
> > > > Why is this a commit for the stable trees? What bug does it fix? You
> > > > did not describe the problem in the changelog text at all, this looks
> > > > like a housekeeping change only.
> > >
> > > Arnd asked for that in:
> > >
> > > Re: [PATCH v11 2/5] tty: goldfish: introduce gf_ioread32()/gf_iowrite32()
> > > https://lore.kernel.org/lkml/CAK8P3a1oN8NrUjkh2X8jHQbyz42Xo6GSa=5n0gD6vQcXRjmq1Q@mail.gmail.com/
> >
> > You did not provide a reason in this changelog to explain any of that :(
>
> OK if I queue that patch with the rationale from Arnd's email added
> to the patch description?
Fine with me, merge away!
next prev parent reply other threads:[~2022-04-11 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 20:15 [PATCH v16 0/4] m68k: Add Virtual M68k Machine Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 1/4] tty: goldfish: introduce gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-04-07 4:48 ` Greg KH
2022-04-07 6:00 ` Laurent Vivier
2022-04-07 6:18 ` Greg KH
2022-04-11 8:53 ` Geert Uytterhoeven
2022-04-11 9:16 ` Greg KH [this message]
2022-04-06 20:15 ` [PATCH v16 2/4] rtc: goldfish: use gf_ioread32()/gf_iowrite32() Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 3/4] clocksource/drivers: Add a goldfish-timer clocksource Laurent Vivier
2022-04-06 20:15 ` [PATCH v16 4/4] m68k: introduce a virtual m68k machine Laurent Vivier
2022-05-31 1:14 ` Randy Dunlap
2022-05-31 6:05 ` Laurent Vivier
2022-05-31 6:20 ` Arnd Bergmann
2022-05-31 16:32 ` Randy Dunlap
2022-04-11 9:55 ` [PATCH v16 0/4] m68k: Add Virtual M68k Machine Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlPx0/u/g9dMYxEn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=geert@linux-m68k.org \
--cc=jiaxun.yang@flygoat.com \
--cc=john.stultz@linaro.org \
--cc=laurent@vivier.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).