From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Mansur Alisha Shaik <mansur@codeaurora.org>,
bryan.odonoghue@linaro.org, linux-media@vger.kernel.org,
stanimir.varbanov@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
vgarodia@codeaurora.org, dikshita@codeaurora.org
Subject: Re: [V3] venus: helper: do not set constrained parameters for UBWC
Date: Sun, 4 Jul 2021 15:00:02 +0100 [thread overview]
Message-ID: <3c3051aa-c897-266e-9648-ca6be933fda0@nexus-software.ie> (raw)
In-Reply-To: <1625202979-23232-1-git-send-email-mansur@codeaurora.org>
On 02/07/2021 06:16, Mansur Alisha Shaik wrote:
> plane constraints firmware interface is to override the default
nitpick this should be "Plane constraints"
> alignment for a given color format. By default venus hardware has
> alignments as 128x32, but NV12 was defined differently to meet
> various usecases. Compressed NV12 has always been aligned as 128x32,
> hence not needed to override the default alignment.
>
> Fixes: bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane constraints to FW")
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
>
> Changes in V3:
> - Elaborated commit message as per comments by Bryan
> - As per Bryan comment alligned fixes in single line.
> ---
> drivers/media/platform/qcom/venus/helpers.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
> index 1fe6d46..601ee3e 100644
> --- a/drivers/media/platform/qcom/venus/helpers.c
> +++ b/drivers/media/platform/qcom/venus/helpers.c
> @@ -1137,8 +1137,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst)
> if (!IS_V6(inst->core))
> return 0;
>
> + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
> + return 0;
> +
> pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
> pconstraint.num_planes = 2;
> +
zap this newline, its not adding anything to your patch
> pconstraint.plane_format[0].stride_multiples = 128;
> pconstraint.plane_format[0].max_stride = 8192;
> pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32;
>
then please add my
"Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>"
---
bod
next prev parent reply other threads:[~2021-07-04 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 5:16 [V3] venus: helper: do not set constrained parameters for UBWC Mansur Alisha Shaik
2021-07-04 14:00 ` Bryan O'Donoghue [this message]
2021-07-04 14:00 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c3051aa-c897-266e-9648-ca6be933fda0@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=bryan.odonoghue@linaro.org \
--cc=dikshita@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mansur@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).