* [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency
@ 2018-03-02 9:47 Baruch Siach
2018-03-02 12:00 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2018-03-02 9:47 UTC (permalink / raw)
To: Linus Walleij
Cc: Stefan Wahren, Dave Stevenson, linux-gpio, linux-kernel,
Baruch Siach, Arnd Bergmann
Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency)
fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not
built-in when the firmware is a module. But the Kconfig syntax for doing
so is cryptic. Add a comment to make it a little easier.
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/gpio/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 52a8b0a6f4e1..1bb25c1ff2d8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -126,6 +126,8 @@ config GPIO_RASPBERRYPI_EXP
tristate "Raspberry Pi 3 GPIO Expander"
default RASPBERRYPI_FIRMWARE
depends on OF_GPIO
+ # Make sure not 'y' when RASPBERRYPI_FIRMWARE is 'm'. This can only
+ # happen when COMPILE_TEST=y, hence the added !RASPBERRYPI_FIRMWARE.
depends on (ARCH_BCM2835 && RASPBERRYPI_FIRMWARE) || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
help
Turn on GPIO support for the expander on Raspberry Pi 3 boards, using
--
2.16.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency
2018-03-02 9:47 [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency Baruch Siach
@ 2018-03-02 12:00 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-03-02 12:00 UTC (permalink / raw)
To: Baruch Siach
Cc: Stefan Wahren, Dave Stevenson, open list:GPIO SUBSYSTEM,
linux-kernel, Arnd Bergmann
On Fri, Mar 2, 2018 at 10:47 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 7ed915059c3001 (gpio: raspberrypi-ext: fix firmware dependency)
> fixed the Kconfig dependency to ensure that gpio-raspberrypi-exp is not
> built-in when the firmware is a module. But the Kconfig syntax for doing
> so is cryptic. Add a comment to make it a little easier.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-02 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-02 9:47 [PATCH] gpio: raspberrypi-exp: explain Kconfig dependency Baruch Siach
2018-03-02 12:00 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).