From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: "David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] netlink: add validation of NLA_F_NESTED flag
Date: Thu, 02 May 2019 17:07:49 +0200 [thread overview]
Message-ID: <3c683fc0d3ea3d07034366a5fbbd5ed5049d48b9.camel@sipsolutions.net> (raw)
In-Reply-To: <20190502131416.GE21672@unicorn.suse.cz>
On Thu, 2019-05-02 at 15:14 +0200, Michal Kubecek wrote:
>
> > > @@ -415,7 +418,8 @@ enum netlink_validation {
> > > #define NL_VALIDATE_STRICT (NL_VALIDATE_TRAILING |\
> > > NL_VALIDATE_MAXTYPE |\
> > > NL_VALIDATE_UNSPEC |\
> > > - NL_VALIDATE_STRICT_ATTRS)
> > > + NL_VALIDATE_STRICT_ATTRS |\
> > > + NL_VALIDATE_NESTED)
> >
> > This is fine _right now_, but in general we cannot keep adding here
> > after the next release :-)
>
> Right, that's why I would like to get this into the same cycle as your
> series.
Yeah, I know you know, just wanted state it again :-)
> How about "NLA_F_NESTED is missing" and "NLA_F_NESTED not expected"?
Looks good to me.
johannes
next prev parent reply other threads:[~2019-05-02 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 12:48 [PATCH net-next 0/3] netlink: strict attribute checking follow-up Michal Kubecek
2019-05-02 12:48 ` [PATCH net-next 1/3] genetlink: do not validate dump requests if there is no policy Michal Kubecek
2019-05-02 12:51 ` Johannes Berg
2019-05-02 13:10 ` Michal Kubecek
2019-05-02 13:13 ` Johannes Berg
2019-05-02 13:32 ` Michal Kubecek
2019-05-02 13:36 ` David Ahern
2019-05-02 15:28 ` Johannes Berg
2019-05-02 12:48 ` [PATCH net-next 3/3] netlink: add validation of NLA_F_NESTED flag Michal Kubecek
2019-05-02 12:54 ` Johannes Berg
2019-05-02 13:14 ` Michal Kubecek
2019-05-02 13:40 ` David Ahern
2019-05-02 15:07 ` Johannes Berg [this message]
2019-05-02 12:48 ` [PATCH net-next 2/3] netlink: set bad attribute also on maxtype check Michal Kubecek
2019-05-02 12:52 ` Johannes Berg
2019-05-02 13:37 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c683fc0d3ea3d07034366a5fbbd5ed5049d48b9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).