linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Kubecek <mkubecek@suse.cz>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
	David Ahern <dsahern@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH net-next 0/3] netlink: strict attribute checking follow-up
Date: Thu,  2 May 2019 14:48:00 +0200 (CEST)	[thread overview]
Message-ID: <cover.1556798793.git.mkubecek@suse.cz> (raw)

Three follow-up patches for recent strict netlink validation series.

Patch 1 fixes dump handling for genetlink families which validate and parse
messages themselves (e.g. because they need different policies for diferent
commands).

Patch 2 sets bad_attr in extack in one place where this was omitted.

Patch 3 adds new NL_VALIDATE_NESTED flags for strict validation to enable
checking that NLA_F_NESTED value in received messages matches expectations
and includes this flag in NL_VALIDATE_STRICT. This would change userspace
visible behavior but the previous switching to NL_VALIDATE_STRICT for new
code is still only in net-next at the moment.

Michal Kubecek (3):
  genetlink: do not validate dump requests if there is no policy
  netlink: set bad attribute also on maxtype check
  netlink: add validation of NLA_F_NESTED flag

 include/net/netlink.h   | 10 +++++++++-
 lib/nlattr.c            | 18 +++++++++++++++++-
 net/netlink/genetlink.c | 24 ++++++++++++++----------
 3 files changed, 40 insertions(+), 12 deletions(-)

-- 
2.21.0


             reply	other threads:[~2019-05-02 12:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-02 12:48 Michal Kubecek [this message]
2019-05-02 12:48 ` [PATCH net-next 1/3] genetlink: do not validate dump requests if there is no policy Michal Kubecek
2019-05-02 12:51   ` Johannes Berg
2019-05-02 13:10     ` Michal Kubecek
2019-05-02 13:13       ` Johannes Berg
2019-05-02 13:32         ` Michal Kubecek
2019-05-02 13:36           ` David Ahern
2019-05-02 15:28             ` Johannes Berg
2019-05-02 12:48 ` [PATCH net-next 3/3] netlink: add validation of NLA_F_NESTED flag Michal Kubecek
2019-05-02 12:54   ` Johannes Berg
2019-05-02 13:14     ` Michal Kubecek
2019-05-02 13:40       ` David Ahern
2019-05-02 15:07       ` Johannes Berg
2019-05-02 12:48 ` [PATCH net-next 2/3] netlink: set bad attribute also on maxtype check Michal Kubecek
2019-05-02 12:52   ` Johannes Berg
2019-05-02 13:37   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1556798793.git.mkubecek@suse.cz \
    --to=mkubecek@suse.cz \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).