* [PATCH] regulator: mcp16502: Fix missing n_voltages setting
@ 2018-12-19 8:58 Axel Lin
2018-12-19 11:45 ` Andrei.Stefanescu
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2018-12-19 8:58 UTC (permalink / raw)
To: Mark Brown
Cc: Andrei Stefanescu, Liam Girdwood, linux-arm-kernel, linux-kernel,
Axel Lin
The n_voltages setting is not set, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/regulator/mcp16502.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
index 25d7b433fafd..ec5b6836a20c 100644
--- a/drivers/regulator/mcp16502.c
+++ b/drivers/regulator/mcp16502.c
@@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)
.ops = &(_ops), \
.type = REGULATOR_VOLTAGE, \
.owner = THIS_MODULE, \
+ .n_voltages = MCP16502_VSEL + 1, \
.linear_ranges = _ranges, \
.n_linear_ranges = ARRAY_SIZE(_ranges), \
.of_match = of_match_ptr(_name), \
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: mcp16502: Fix missing n_voltages setting
2018-12-19 8:58 [PATCH] regulator: mcp16502: Fix missing n_voltages setting Axel Lin
@ 2018-12-19 11:45 ` Andrei.Stefanescu
0 siblings, 0 replies; 2+ messages in thread
From: Andrei.Stefanescu @ 2018-12-19 11:45 UTC (permalink / raw)
To: axel.lin, broonie
Cc: lgirdwood, linux-arm-kernel, linux-kernel, Cristian.Birsan,
Claudiu.Beznea, Nicolas.Ferre
Hi Axel,
Thank you for the patch!
However, there are not MCP16502_VSEL + 1 voltages,
but VDD_HIGH_SEL - VDD_LOW_SEL + 1 (=51).
Best regards,
Andrei
On 19.12.2018 10:58, Axel Lin wrote:
> The n_voltages setting is not set, fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/mcp16502.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c
> index 25d7b433fafd..ec5b6836a20c 100644
> --- a/drivers/regulator/mcp16502.c
> +++ b/drivers/regulator/mcp16502.c
> @@ -90,6 +90,7 @@ static unsigned int mcp16502_of_map_mode(unsigned int mode)
> .ops = &(_ops), \
> .type = REGULATOR_VOLTAGE, \
> .owner = THIS_MODULE, \
> + .n_voltages = MCP16502_VSEL + 1, \
> .linear_ranges = _ranges, \
> .n_linear_ranges = ARRAY_SIZE(_ranges), \
> .of_match = of_match_ptr(_name), \
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-19 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 8:58 [PATCH] regulator: mcp16502: Fix missing n_voltages setting Axel Lin
2018-12-19 11:45 ` Andrei.Stefanescu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).