* [PATCH] n64cart: fix return value check in n64cart_probe()
@ 2021-09-09 9:06 Yang Yingliang
2021-09-09 16:17 ` Chaitanya Kulkarni
2021-09-09 20:24 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-09-09 9:06 UTC (permalink / raw)
To: linux-kernel, linux-block; +Cc: axboe
In case of error, the function devm_platform_ioremap_resource()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/block/n64cart.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c
index c84be0028f63..26798da661bd 100644
--- a/drivers/block/n64cart.c
+++ b/drivers/block/n64cart.c
@@ -129,8 +129,8 @@ static int __init n64cart_probe(struct platform_device *pdev)
}
reg_base = devm_platform_ioremap_resource(pdev, 0);
- if (!reg_base)
- return -EINVAL;
+ if (IS_ERR(reg_base))
+ return PTR_ERR(reg_base);
disk = blk_alloc_disk(NUMA_NO_NODE);
if (!disk)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] n64cart: fix return value check in n64cart_probe()
2021-09-09 9:06 [PATCH] n64cart: fix return value check in n64cart_probe() Yang Yingliang
@ 2021-09-09 16:17 ` Chaitanya Kulkarni
2021-09-09 20:24 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2021-09-09 16:17 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-block; +Cc: axboe
On 9/9/21 2:06 AM, Yang Yingliang wrote:
> External email: Use caution opening links or attachments
>
>
> In case of error, the function devm_platform_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] n64cart: fix return value check in n64cart_probe()
2021-09-09 9:06 [PATCH] n64cart: fix return value check in n64cart_probe() Yang Yingliang
2021-09-09 16:17 ` Chaitanya Kulkarni
@ 2021-09-09 20:24 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-09-09 20:24 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, linux-block
On 9/9/21 3:06 AM, Yang Yingliang wrote:
> In case of error, the function devm_platform_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-09 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-09 9:06 [PATCH] n64cart: fix return value check in n64cart_probe() Yang Yingliang
2021-09-09 16:17 ` Chaitanya Kulkarni
2021-09-09 20:24 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).