From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shli@fb.com>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <Kernel-team@fb.com>
Subject: Re: [PATCH V2 2/2] blk-mq: immediately dispatch big size request
Date: Fri, 4 Nov 2016 09:29:07 -0600 [thread overview]
Message-ID: <3d7144e3-47e5-3c98-489f-e92d97b60817@fb.com> (raw)
In-Reply-To: <20161104144614.GA18373@infradead.org>
On 11/04/2016 08:46 AM, Christoph Hellwig wrote:
> On Thu, Nov 03, 2016 at 10:00:58PM -0600, Jens Axboe wrote:
>> I've applied 1-2 for 4.10, but we probably should look into unifying
>> those parts of sq and mq in general. For instance, it doesn't seem to
>> make a lot of sense why we'd depth limit sq and not mq.
>
> I've spent some time looking the the make_request_fn and to be honest
> I think that whole sq vs mq split is pointless. They are about 70-80%
> the same anyway, and I think everyone would be served much better
> by merging them.
Yeah, that was my point, at least if we can do it without having too
many extra conditionals. Or at least split some of it into helpers.
--
Jens Axboe
prev parent reply other threads:[~2016-11-04 15:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:03 [PATCH V2 1/2] block: immediately dispatch big size request Shaohua Li
2016-11-04 0:03 ` [PATCH V2 2/2] blk-mq: " Shaohua Li
2016-11-04 0:09 ` Christoph Hellwig
2016-11-04 0:13 ` Shaohua Li
2016-11-04 4:00 ` Jens Axboe
2016-11-04 14:46 ` Christoph Hellwig
2016-11-04 15:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d7144e3-47e5-3c98-489f-e92d97b60817@fb.com \
--to=axboe@fb.com \
--cc=Kernel-team@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).