* [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC
@ 2020-07-30 6:15 Dilip Kota
2020-07-30 7:57 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Dilip Kota @ 2020-07-30 6:15 UTC (permalink / raw)
To: x86, tglx, mingo, bp, hpa, rahul.tanwar
Cc: hdegoede, linux-kernel, andy, cheol.yong.kim, chuanhua.lei,
qi-ming.wu, Dilip Kota
Frequency descriptor of Lightning Mountain SoC doesn't have all the
frequency entries so resulting in the below failure causing kernel hang.
[ 0.000000] Error MSR_FSB_FREQ index 15 is unknown
[ 0.000000] tsc: Fast TSC calibration failed
So, add all the frequency entries in the Lightning Mountain SoC frequency
descriptor.
Fixes: 0cc5359d8fd45 ("x86/cpu: Update init data for new Airmont CPU model")
Fixes: 812c2d7506fd ("x86/tsc_msr: Use named struct initializers")
Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
---
arch/x86/kernel/tsc_msr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/tsc_msr.c b/arch/x86/kernel/tsc_msr.c
index 4fec6f3a1858b2..c255e10e914aa5 100644
--- a/arch/x86/kernel/tsc_msr.c
+++ b/arch/x86/kernel/tsc_msr.c
@@ -136,7 +136,8 @@ static const struct freq_desc freq_desc_ann = {
/* 24 MHz crystal? : 24 * 13 / 4 = 78 MHz */
static const struct freq_desc freq_desc_lgm = {
.use_msr_plat = true,
- .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
+ .freqs = { 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000, 78000,
+ 78000, 78000, 78000, 78000, 78000, 78000, 78000 },
.mask = 0x0f,
};
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC
2020-07-30 6:15 [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC Dilip Kota
@ 2020-07-30 7:57 ` Andy Shevchenko
2020-07-30 9:51 ` Dilip Kota
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-07-30 7:57 UTC (permalink / raw)
To: Dilip Kota
Cc: maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Tanwar, Rahul, Hans de Goede, Linux Kernel Mailing List,
Andy Shevchenko, cheol.yong.kim, chuanhua.lei, qi-ming.wu
On Thu, Jul 30, 2020 at 9:16 AM Dilip Kota <eswara.kota@linux.intel.com> wrote:
>
> Frequency descriptor of Lightning Mountain SoC doesn't have all the
> frequency entries so resulting in the below failure causing kernel hang.
>
> [ 0.000000] Error MSR_FSB_FREQ index 15 is unknown
> [ 0.000000] tsc: Fast TSC calibration failed
>
> So, add all the frequency entries in the Lightning Mountain SoC frequency
> descriptor.
While at this, can you confirm (with maybe good description and
documentation reference) that the numbers in that array are all
correct?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC
2020-07-30 7:57 ` Andy Shevchenko
@ 2020-07-30 9:51 ` Dilip Kota
0 siblings, 0 replies; 3+ messages in thread
From: Dilip Kota @ 2020-07-30 9:51 UTC (permalink / raw)
To: Andy Shevchenko
Cc: maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
Thomas Gleixner, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
Tanwar, Rahul, Hans de Goede, Linux Kernel Mailing List,
Andy Shevchenko, cheol.yong.kim, chuanhua.lei, qi-ming.wu
On 7/30/2020 3:57 PM, Andy Shevchenko wrote:
> While at this, can you confirm (with maybe good description and
> documentation reference) that the numbers in that array are all
> correct?
Sure, i will add the description.
Regards,
Dilip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-30 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 6:15 [PATCH 1/1] x86/tsr: Fix tsc frequency enumeration failure on lightning mountain SoC Dilip Kota
2020-07-30 7:57 ` Andy Shevchenko
2020-07-30 9:51 ` Dilip Kota
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).