From: Gao Xiang <gaoxiang25@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <devel@driverdev.osuosl.org>, <linux-erofs@lists.ozlabs.org>,
"Loic Tourlonias" <loic.tourlonias.lkml@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: erofs: add SPDX identifer
Date: Mon, 8 Oct 2018 22:41:53 +0800 [thread overview]
Message-ID: <3dedd0e3-f5eb-8131-a1e9-f04624381cd8@huawei.com> (raw)
In-Reply-To: <e9620bf6-5f3f-108d-b9f1-91af1ad603d6@huawei.com>
On 2018/10/8 22:36, Gao Xiang wrote:
> Hi Greg,
>
> On 2018/10/8 22:22, Greg Kroah-Hartman wrote:
>> Why delete that line?
>>
>> But wait, why do we even have this file at all? What's wrong with the
>> lib/lz4/ code that we have in the kernel today? Shouldn't the code
>> using these files be moved over to use the lib/ code instead and this
>> file be deleted?
>
> EROFS uses customized LZ4 decompression code for now (which has been offically
> supported in lz4 1.8.3, I have updated it in
> https://ozlabs.org/~akpm/mmots/broken-out/lib-lz4-update-lz4-decompressor-module.patch
> if it is shown up in Linux 4.20, I will remove all the customized LZ4 decompression code),
> but lib/ code lz4def.h isn't export to include/.
Please refer to https://github.com/lz4/lz4/issues/566 for more details the reason why
EROFS uses the different implementation rather than the current lib/lz4/ code in the kernel today
(it will be changed in the next Linux version if the updated code works fine.)
Thanks,
Gao Xiang
>
> Thanks,
> Gao Xiang
>
>>
>> thanks,
>>
>> greg k-h
next prev parent reply other threads:[~2018-10-08 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 14:14 [PATCH v2] staging: erofs: add SPDX identifer Loic Tourlonias
2018-10-08 14:22 ` Greg Kroah-Hartman
2018-10-08 14:36 ` Gao Xiang
2018-10-08 14:41 ` Gao Xiang [this message]
2018-10-08 14:43 ` Greg Kroah-Hartman
2018-10-08 14:48 ` Gao Xiang
2018-10-08 15:00 ` loïc tourlonias
2018-10-08 15:02 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dedd0e3-f5eb-8131-a1e9-f04624381cd8@huawei.com \
--to=gaoxiang25@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.tourlonias.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).