* [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()
@ 2022-04-29 9:01 cgel.zte
2022-04-29 10:25 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-04-29 9:01 UTC (permalink / raw)
To: tomba; +Cc: airlied, dri-devel, linux-kernel, Minghao Chi, Zeal Robot
From: Minghao Chi <chi.minghao@zte.com.cn>
Simplify the return expression.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
index eea719243eaf..10c6b3e492d3 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
@@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss,
{
struct dss_pll *pll = &hpll->pll;
struct clk *clk;
- int r;
clk = devm_clk_get(&pdev->dev, "sys_clk");
if (IS_ERR(clk)) {
@@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss,
pll->ops = &hdmi_pll_ops;
- r = dss_pll_register(dss, pll);
- if (r)
- return r;
-
- return 0;
+ return dss_pll_register(dss, pll);
}
int hdmi_pll_init(struct dss_device *dss, struct platform_device *pdev,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data()
2022-04-29 9:01 [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data() cgel.zte
@ 2022-04-29 10:25 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2022-04-29 10:25 UTC (permalink / raw)
To: cgel.zte; +Cc: airlied, dri-devel, linux-kernel, Minghao Chi, Zeal Robot
On 29/04/2022 12:01, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> index eea719243eaf..10c6b3e492d3 100644
> --- a/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi_pll.c
> @@ -131,7 +131,6 @@ static int hdmi_init_pll_data(struct dss_device *dss,
> {
> struct dss_pll *pll = &hpll->pll;
> struct clk *clk;
> - int r;
>
> clk = devm_clk_get(&pdev->dev, "sys_clk");
> if (IS_ERR(clk)) {
> @@ -151,11 +150,7 @@ static int hdmi_init_pll_data(struct dss_device *dss,
>
> pll->ops = &hdmi_pll_ops;
>
> - r = dss_pll_register(dss, pll);
> - if (r)
> - return r;
> -
> - return 0;
> + return dss_pll_register(dss, pll);
> }
This is a rather pointless change, and I personally like the current
style better.
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 9:01 [PATCH] omapdss: HDMI: simplify the return expression of hdmi_init_pll_data() cgel.zte
2022-04-29 10:25 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).