[PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

[PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

[Krzysztof Kozlowski]

The iMX DRM drivers use Common Clock Framework thus they cannot be built
on platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
    imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/gpu/drm/imx/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index 6231048aa5aa..65f9ef625337 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -5,7 +5,8 @@ config DRM_IMX
 	select VIDEOMODE_HELPERS
 	select DRM_GEM_CMA_HELPER
 	select DRM_KMS_CMA_HELPER
-	depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
+	depends on DRM
+	depends on ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST && COMMON_CLK
 	depends on IMX_IPUV3_CORE
 	help
 	  enable i.MX graphics support
-- 
2.25.1

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

[Philipp Zabel]

On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote:
> The iMX DRM drivers use Common Clock Framework thus they cannot be built
> on platforms without it (e.g. compile test on MIPS with RALINK and
> SOC_RT305X):
> 
>     /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
>     imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Thank you, but could this be added to

config DRM_IMX_LDB

instead?

The core DRM_IMX code does not use the Common Clock Framework directly.
DRM_IMX_TVE already depends on COMMON_CLK because it implements a clock.

regards
Philipp

Re: [PATCH] drm/imx: depend on COMMON_CLK to fix compile tests

[Krzysztof Kozlowski]

On Tue, 17 Nov 2020 at 11:56, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Mon, 2020-11-16 at 19:14 +0100, Krzysztof Kozlowski wrote:
> > The iMX DRM drivers use Common Clock Framework thus they cannot be built
> > on platforms without it (e.g. compile test on MIPS with RALINK and
> > SOC_RT305X):
> >
> >     /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/imx/imx-ldb.o: in function `imx_ldb_encoder_disable':
> >     imx-ldb.c:(.text+0x400): undefined reference to `clk_set_parent'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Thank you, but could this be added to
>
> config DRM_IMX_LDB
>
> instead?
>
> The core DRM_IMX code does not use the Common Clock Framework directly.
> DRM_IMX_TVE already depends on COMMON_CLK because it implements a clock.

You're right, I even wanted to add it there but somehow it landed in
the main entry... Thanks, I'll send a v2.

Best regards,
Krzysztof