* [PATCH] video: fbdev: pvr2fb: fix compile-testing as module
@ 2019-06-17 12:47 ` Arnd Bergmann
2019-06-21 11:15 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2019-06-17 12:47 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Arnd Bergmann, Mike Marshall, YueHaibing, Ira Weiny, dri-devel,
linux-fbdev, linux-kernel
Building an allmodconfig kernel now produces a harmless warning:
drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function]
Shut this up the same way as we do for other unused functions
in the same file, using the __maybe_unused attribute.
Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/pvr2fb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
index 59c59b3a67cb..cf9cfdc5e685 100644
--- a/drivers/video/fbdev/pvr2fb.c
+++ b/drivers/video/fbdev/pvr2fb.c
@@ -723,8 +723,8 @@ static struct fb_ops pvr2fb_ops = {
.fb_imageblit = cfb_imageblit,
};
-static int pvr2_get_param_val(const struct pvr2_params *p, const char *s,
- int size)
+static int __maybe_unused pvr2_get_param_val(const struct pvr2_params *p,
+ const char *s, int size)
{
int i;
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix compile-testing as module
2019-06-17 12:47 ` [PATCH] video: fbdev: pvr2fb: fix compile-testing as module Arnd Bergmann
@ 2019-06-21 11:15 ` Bartlomiej Zolnierkiewicz
2019-06-21 14:22 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-21 11:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mike Marshall, YueHaibing, Ira Weiny, dri-devel, linux-fbdev,
linux-kernel
On 6/17/19 2:47 PM, Arnd Bergmann wrote:
> Building an allmodconfig kernel now produces a harmless warning:
>
> drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function]
>
> Shut this up the same way as we do for other unused functions
> in the same file, using the __maybe_unused attribute.
>
> Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks but I've fixed it already by adding #ifndef MODULE (since other
functions in the same file using __maybe_unused depend on either PCI or
SH_DREAMCAST I've preferred not to use this attribute):
https://marc.info/?l=linux-fbdev&m=156050904010778&w=2
> ---
> drivers/video/fbdev/pvr2fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c
> index 59c59b3a67cb..cf9cfdc5e685 100644
> --- a/drivers/video/fbdev/pvr2fb.c
> +++ b/drivers/video/fbdev/pvr2fb.c
> @@ -723,8 +723,8 @@ static struct fb_ops pvr2fb_ops = {
> .fb_imageblit = cfb_imageblit,
> };
>
> -static int pvr2_get_param_val(const struct pvr2_params *p, const char *s,
> - int size)
> +static int __maybe_unused pvr2_get_param_val(const struct pvr2_params *p,
> + const char *s, int size)
> {
> int i;
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pvr2fb: fix compile-testing as module
2019-06-21 11:15 ` Bartlomiej Zolnierkiewicz
@ 2019-06-21 14:22 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2019-06-21 14:22 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Mike Marshall, YueHaibing, Ira Weiny, dri-devel,
Linux Fbdev development list, Linux Kernel Mailing List
On Fri, Jun 21, 2019 at 1:15 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
>
> On 6/17/19 2:47 PM, Arnd Bergmann wrote:
> > Building an allmodconfig kernel now produces a harmless warning:
> >
> > drivers/video/fbdev/pvr2fb.c:726:12: error: unused function 'pvr2_get_param_val' [-Werror,-Wunused-function]
> >
> > Shut this up the same way as we do for other unused functions
> > in the same file, using the __maybe_unused attribute.
> >
> > Fixes: 0f5a5712ad1e ("video: fbdev: pvr2fb: add COMPILE_TEST support")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks but I've fixed it already by adding #ifndef MODULE (since other
> functions in the same file using __maybe_unused depend on either PCI or
> SH_DREAMCAST I've preferred not to use this attribute):
>
> https://marc.info/?l=linux-fbdev&m=156050904010778&w=2
Ok, dropping my patch from the local queue, your version is obviously
correct as well.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-21 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190617124822epcas2p2c93d6cec3b60d08d85f228945d5c7623@epcas2p2.samsung.com>
2019-06-17 12:47 ` [PATCH] video: fbdev: pvr2fb: fix compile-testing as module Arnd Bergmann
2019-06-21 11:15 ` Bartlomiej Zolnierkiewicz
2019-06-21 14:22 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).