* [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
@ 2022-06-27 9:12 Kavyasree Kotagiri
2022-07-01 8:17 ` Nicolas Ferre
2022-07-01 8:32 ` Claudiu.Beznea
0 siblings, 2 replies; 3+ messages in thread
From: Kavyasree Kotagiri @ 2022-06-27 9:12 UTC (permalink / raw)
To: arnd, alexandre.belloni, krzysztof.kozlowski+dt, soc, robh+dt,
nicolas.ferre
Cc: linux-arm-kernel, devicetree, linux-kernel, UNGLinuxDriver,
Kavyasree.Kotagiri
On pcb8291, Flexcom3 usart has only tx and rx pins.
Cleaningup usart3 pinctrl settings.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index 3c7e3a7d6f14..5dc8ed4cee9a 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -19,19 +19,13 @@
};
&gpio {
- fc_shrd7_pins: fc_shrd7-pins {
- pins = "GPIO_49";
- function = "fc_shrd7";
- };
-
- fc_shrd8_pins: fc_shrd8-pins {
- pins = "GPIO_54";
- function = "fc_shrd8";
+ fc3_b_rxd_pins: fc3-b-rxd-pins {
+ pins = "GPIO_52";
+ function = "fc3_b";
};
- fc3_b_pins: fcb3-spi-pins {
- /* SCK, RXD, TXD */
- pins = "GPIO_51", "GPIO_52", "GPIO_53";
+ fc3_b_txd_pins: fc3-b-txd-pins {
+ pins = "GPIO_53";
function = "fc3_b";
};
@@ -53,7 +47,7 @@
status = "okay";
usart3: serial@200 {
- pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
+ pinctrl-0 = <&fc3_b_rxd_pins>, <&fc3_b_txd_pins>;
pinctrl-names = "default";
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
2022-06-27 9:12 [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
@ 2022-07-01 8:17 ` Nicolas Ferre
2022-07-01 8:32 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2022-07-01 8:17 UTC (permalink / raw)
To: Kavyasree Kotagiri, arnd, alexandre.belloni,
krzysztof.kozlowski+dt, soc, robh+dt, Claudiu Beznea
Cc: linux-arm-kernel, devicetree, linux-kernel, UNGLinuxDriver
On 27/06/2022 at 11:12, Kavyasree Kotagiri wrote:
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Okay, looks good to me:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
We'll integrate it in our next dt branch that we'll build for arm-soc.
Best regards,
Nicolas
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..5dc8ed4cee9a 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,13 @@
> };
>
> &gpio {
> - fc_shrd7_pins: fc_shrd7-pins {
> - pins = "GPIO_49";
> - function = "fc_shrd7";
> - };
> -
> - fc_shrd8_pins: fc_shrd8-pins {
> - pins = "GPIO_54";
> - function = "fc_shrd8";
> + fc3_b_rxd_pins: fc3-b-rxd-pins {
> + pins = "GPIO_52";
> + function = "fc3_b";
> };
>
> - fc3_b_pins: fcb3-spi-pins {
> - /* SCK, RXD, TXD */
> - pins = "GPIO_51", "GPIO_52", "GPIO_53";
> + fc3_b_txd_pins: fc3-b-txd-pins {
> + pins = "GPIO_53";
> function = "fc3_b";
> };
>
> @@ -53,7 +47,7 @@
> status = "okay";
>
> usart3: serial@200 {
> - pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> + pinctrl-0 = <&fc3_b_rxd_pins>, <&fc3_b_txd_pins>;
> pinctrl-names = "default";
> status = "okay";
> };
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
2022-06-27 9:12 [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
2022-07-01 8:17 ` Nicolas Ferre
@ 2022-07-01 8:32 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2022-07-01 8:32 UTC (permalink / raw)
To: Kavyasree.Kotagiri, arnd, alexandre.belloni,
krzysztof.kozlowski+dt, soc, robh+dt, Nicolas.Ferre
Cc: linux-arm-kernel, devicetree, linux-kernel, UNGLinuxDriver
On 27.06.2022 12:12, Kavyasree Kotagiri wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..5dc8ed4cee9a 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,13 @@
> };
>
> &gpio {
> - fc_shrd7_pins: fc_shrd7-pins {
> - pins = "GPIO_49";
> - function = "fc_shrd7";
> - };
> -
> - fc_shrd8_pins: fc_shrd8-pins {
> - pins = "GPIO_54";
> - function = "fc_shrd8";
> + fc3_b_rxd_pins: fc3-b-rxd-pins {
> + pins = "GPIO_52";
> + function = "fc3_b";
> };
>
> - fc3_b_pins: fcb3-spi-pins {
> - /* SCK, RXD, TXD */
> - pins = "GPIO_51", "GPIO_52", "GPIO_53";
> + fc3_b_txd_pins: fc3-b-txd-pins {
> + pins = "GPIO_53";
Could we keep both pins under the same node? As in case of can0_b_pins,
something like:
fc3_b_pins: fc3-b-pins {
pins = "GPIO_52", "GPIO_53";
function = "fc3_b";
};
Thank you,
Claudiu Beznea
> function = "fc3_b";
> };
>
> @@ -53,7 +47,7 @@
> status = "okay";
>
> usart3: serial@200 {
> - pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> + pinctrl-0 = <&fc3_b_rxd_pins>, <&fc3_b_txd_pins>;
> pinctrl-names = "default";
> status = "okay";
> };
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-01 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 9:12 [PATCH] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
2022-07-01 8:17 ` Nicolas Ferre
2022-07-01 8:32 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).