From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: linux-kernel@vger.kernel.org
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH linux-next] drm/i915/request: Remove unused variables
Date: Sun, 21 Nov 2021 13:18:09 +0100 [thread overview]
Message-ID: <3f420d7d-2f9e-c7e2-e5ac-8200e87781cb@wanadoo.fr> (raw)
In-Reply-To: <20211121101309.23577-1-yong.yiran@zte.com.cn>
Le 21/11/2021 à 11:13, cgel.zte@gmail.com a écrit :
> From: yong yiran <yong.yiran@zte.com.cn>
>
> The clang_analyzer complains as follows:
> drivers/gpu/drm/i915/i915_request.c:2119:2 warning:
> Value stored to 'x' is never read
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
> ---
> drivers/gpu/drm/i915/i915_request.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 820a1f38b271..5e4420f461e9 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -2047,7 +2047,6 @@ void i915_request_show(struct drm_printer *m,
> {
> const char *name = rq->fence.ops->get_timeline_name((struct dma_fence *)&rq->fence);
> char buf[80] = "";
> - int x = 0;
>
> /*
> * The prefix is used to show the queue status, for which we use
> @@ -2079,8 +2078,6 @@ void i915_request_show(struct drm_printer *m,
> * from the lists
> */
>
> - x = print_sched_attr(&rq->sched.attr, buf, x, sizeof(buf));
> -
Seriously?
CJ
> drm_printf(m, "%s%.*s%c %llx:%lld%s%s %s @ %dms: %s\n",
> prefix, indent, " ",
> queue_status(rq),
>
next prev parent reply other threads:[~2021-11-21 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 10:13 [PATCH linux-next] drm/i915/request: Remove unused variables cgel.zte
2021-11-21 12:18 ` Christophe JAILLET [this message]
2021-11-21 12:18 ` Christophe JAILLET
2021-11-22 9:09 ` Jani Nikula
2021-11-22 6:48 ` kernel test robot
2021-11-22 7:08 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f420d7d-2f9e-c7e2-e5ac-8200e87781cb@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).