From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations
Date: Mon, 02 Aug 2021 01:35:35 -0700 [thread overview]
Message-ID: <3f55848b4612d1b17d95a4c36bec1dee2b1814f1.camel@perches.com> (raw)
In-Reply-To: <20210731124044.101927-1-colin.king@canonical.com>
On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variables rtstatus and place are being initialized with a values that
> are never read, the initializations are redundant and can be removed.
trivia:
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
[]
> @@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
> 132, 134, 136, 138, 140, 149, 151, 153, 155,
> 157, 159, 161, 163, 165
> };
> - u8 place = chnl;
> + u8 place;
>
>
> if (chnl > 14) {
> for (place = 14; place < sizeof(channel_all); place++) {
This line should probably be
for (place = 14; place < ARRAY_SIZE(channel_all); place++) {
next prev parent reply other threads:[~2021-08-02 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 12:40 [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Colin King
2021-07-31 12:40 ` [PATCH 2/2] rtlwifi: rtl8192de: make arrays static const, makes object smaller Colin King
2021-08-02 8:04 ` Pkshih
2021-08-02 8:35 ` Joe Perches
2021-08-03 14:03 ` Colin Ian King
2021-08-02 8:04 ` [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Pkshih
2021-08-02 8:35 ` Joe Perches [this message]
2021-08-03 14:03 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f55848b4612d1b17d95a4c36bec1dee2b1814f1.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).