* [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2021-02-06 7:10 winndows
2021-02-10 15:56 ` Josef Bacik
2021-02-10 16:39 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: winndows @ 2021-02-06 7:10 UTC (permalink / raw)
To: josef, axboe; +Cc: linux-block, nbd, linux-kernel, Liao Pingfang
From: Liao Pingfang <winndows@163.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Liao Pingfang <winndows@163.com>
---
drivers/block/nbd.c | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index e6ea5d3..8b9622e 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -1529,17 +1529,7 @@ static int nbd_dbg_tasks_show(struct seq_file *s, void *unused)
return 0;
}
-static int nbd_dbg_tasks_open(struct inode *inode, struct file *file)
-{
- return single_open(file, nbd_dbg_tasks_show, inode->i_private);
-}
-
-static const struct file_operations nbd_dbg_tasks_ops = {
- .open = nbd_dbg_tasks_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(nbd_dbg_tasks);
static int nbd_dbg_flags_show(struct seq_file *s, void *unused)
{
@@ -1564,17 +1554,7 @@ static int nbd_dbg_flags_show(struct seq_file *s, void *unused)
return 0;
}
-static int nbd_dbg_flags_open(struct inode *inode, struct file *file)
-{
- return single_open(file, nbd_dbg_flags_show, inode->i_private);
-}
-
-static const struct file_operations nbd_dbg_flags_ops = {
- .open = nbd_dbg_flags_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(nbd_dbg_flags);
static int nbd_dev_dbg_init(struct nbd_device *nbd)
{
@@ -1592,11 +1572,11 @@ static int nbd_dev_dbg_init(struct nbd_device *nbd)
}
config->dbg_dir = dir;
- debugfs_create_file("tasks", 0444, dir, nbd, &nbd_dbg_tasks_ops);
+ debugfs_create_file("tasks", 0444, dir, nbd, &nbd_dbg_tasks_fops);
debugfs_create_u64("size_bytes", 0444, dir, &config->bytesize);
debugfs_create_u32("timeout", 0444, dir, &nbd->tag_set.timeout);
debugfs_create_u64("blocksize", 0444, dir, &config->blksize);
- debugfs_create_file("flags", 0444, dir, nbd, &nbd_dbg_flags_ops);
+ debugfs_create_file("flags", 0444, dir, nbd, &nbd_dbg_flags_fops);
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE
2021-02-06 7:10 [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE winndows
@ 2021-02-10 15:56 ` Josef Bacik
2021-02-10 16:39 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Josef Bacik @ 2021-02-10 15:56 UTC (permalink / raw)
To: winndows, axboe; +Cc: linux-block, nbd, linux-kernel
On 2/6/21 2:10 AM, winndows@163.com wrote:
> From: Liao Pingfang <winndows@163.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Liao Pingfang <winndows@163.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE
2021-02-06 7:10 [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE winndows
2021-02-10 15:56 ` Josef Bacik
@ 2021-02-10 16:39 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2021-02-10 16:39 UTC (permalink / raw)
To: winndows, josef; +Cc: linux-block, nbd, linux-kernel
On 2/6/21 12:10 AM, winndows@163.com wrote:
> From: Liao Pingfang <winndows@163.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-10 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-06 7:10 [PATCH] nbd: Convert to DEFINE_SHOW_ATTRIBUTE winndows
2021-02-10 15:56 ` Josef Bacik
2021-02-10 16:39 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).