linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Wen He <wen.he_1@nxp.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>
Cc: Leo Li <leoyang.li@nxp.com>
Subject: Re: [v1] drm/arm/mali-dp: Disable checking for required pixel clock rate
Date: Wed, 15 May 2019 18:14:10 +0100	[thread overview]
Message-ID: <3f87b2a7-c7e8-0597-2f62-d421aa6ccaa5@arm.com> (raw)
In-Reply-To: <20190515024348.43642-1-wen.he_1@nxp.com>

On 15/05/2019 03:42, Wen He wrote:
> Disable checking for required pixel clock rate if ARCH_LAYERSCPAE
> is enable.
> 
> Signed-off-by: Alison Wang <alison.wang@nxp.com>
> Signed-off-by: Wen He <wen.he_1@nxp.com>
> ---
> change in description:
> 	- This check that only supported one pixel clock required clock rate
> 	compare with dts node value. but we have supports 4 pixel clock
> 	for ls1028a board.
>   drivers/gpu/drm/arm/malidp_crtc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
> index 56aad288666e..bb79223d9981 100644
> --- a/drivers/gpu/drm/arm/malidp_crtc.c
> +++ b/drivers/gpu/drm/arm/malidp_crtc.c
> @@ -36,11 +36,13 @@ static enum drm_mode_status malidp_crtc_mode_valid(struct drm_crtc *crtc,
>   
>   	if (req_rate) {
>   		rate = clk_round_rate(hwdev->pxlclk, req_rate);
> +#ifndef CONFIG_ARCH_LAYERSCAPE

What about multiplatform builds? The kernel config doesn't tell you what 
hardware you're actually running on.

Robin.

>   		if (rate != req_rate) {
>   			DRM_DEBUG_DRIVER("pxlclk doesn't support %ld Hz\n",
>   					 req_rate);
>   			return MODE_NOCLOCK;
>   		}
> +#endif
>   	}
>   
>   	return MODE_OK;
> 

  parent reply	other threads:[~2019-05-15 17:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15  2:42 [v1] drm/arm/mali-dp: Disable checking for required pixel clock rate Wen He
2019-05-15 15:45 ` liviu.dudau
2019-05-16  8:10   ` [EXT] " Wen He
2019-05-16  8:23     ` liviu.dudau
2019-05-17 10:38       ` Wen He
2019-05-17 16:17         ` liviu.dudau
2019-05-15 17:14 ` Robin Murphy [this message]
2019-05-16  9:42   ` Wen He
2019-05-16 10:45     ` Robin Murphy
2019-05-17 10:37       ` Wen He
2019-05-17 16:13         ` liviu.dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f87b2a7-c7e8-0597-2f62-d421aa6ccaa5@arm.com \
    --to=robin.murphy@arm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=wen.he_1@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).